Merged
Conversation
vjardin
requested changes
Nov 20, 2025
Owner
vjardin
left a comment
vjardin
left a comment
There was a problem hiding this comment.
some few cosmetic changes are needed.
Collaborator
Author
|
ok |
thbtcllt
commented
Nov 24, 2025
Collaborator
Author
thbtcllt
left a comment
thbtcllt
left a comment
There was a problem hiding this comment.
Just one comment about use of goto
added 5 commits
November 24, 2025 14:46
Purpose of this command is to: - be able to configure any BMR where commands behavior is different from 456 or 685 - access non documented commands (if any)
Use the same order of the get that is more logical Fault configuration for voltage or intensity will be added later.
Useless call:
json_object_set_new(o, key + (sizeof("") - 1), json_object_get(o, key))
break the json object and then call to json_print_or_pretty do a
segfault as json_dumps return NULL and this case is not checked before
calling put(s)
A check is added in function json_print_or_pretty to avoid the segfault
(an error message is displayed) and useless call is removed.
Save and restore are required for any commands and not only for the USER_DATA. Two new commands are created for that and README is changed accordingly. For these new commands BMT456 does not exepct call to sendbyte but a write byte on the command with a dummy value. A test is done on the BMR version to know how to execute the command. Moreover for the restore two options are provided to reload the default configuration or the last saved configuration. No automatic save is done after a restore.
vjardin
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as previous one but after reforking original project to fix issue related to a push force that changes the sha of some commits