Open
Conversation
Doesn't the original code reverse t *destructively*? Javascript passes objects mutably, so when you've assigned to t.left and t.right, you've altered the original tree. This doesn't affect the answer you get out of isSymmetric (as long as the two subtrees do not share structure, i.e. you're not actually working with a graph), but would be a very unexpected side-effect for a user of isSymmetric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't the original code reverse t destructively? Javascript passes objects mutably, so when you've assigned to t.left and t.right, you've altered the original tree. This doesn't affect the answer you get out of isSymmetric (as long as the two subtrees do not share structure, i.e. you're not actually working with a graph), but would be a very unexpected side-effect for a user of isSymmetric.