Skip to content

Bump the astro group across 1 directory with 5 updates #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump the astro group across 1 directory with 5 updates #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b9e8b8
Bump the astro group across 1 directory with 5 updates
dependabot[bot] Feb 23, 2025
82abca4
Give drags a bit more time to set up by hovering once before dragging.
jyasskin Feb 23, 2025
8c688ca
Expand the problematic drag to include an extra mouse move.
jyasskin Feb 23, 2025
ed455fb
Give the ingredients a bigger hit box for dragging.
jyasskin Feb 23, 2025
b4f3137
Try dragging from a bit inside the element.
jyasskin Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions webserver/e2e/edit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,19 @@
const ingredients = page.getByRole("group")
.filter({ has: page.getByRole("heading", { name: "Ingredients" }) })
.getByRole("listitem");
await ingredients.nth(0).dragTo(ingredients.nth(2), { sourcePosition: { x: 0, y: 0 } });
await ingredients.nth(1).dragTo(ingredients.nth(0), { sourcePosition: { x: 0, y: 0 } });
await ingredients.nth(0).dragTo(ingredients.nth(2), { sourcePosition: { x: 1, y: 5 } });
await ingredients.nth(1).hover({ position: { x:1, y:10 } });
await page.mouse.down();
await ingredients.nth(0).hover();
await ingredients.nth(0).hover(); // Give the drag some more time to land.
await page.mouse.up();
await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");

Check failure on line 166 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
    Expected string: "Spices"
    Received string: "sucre"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" value="sucre" list="all-ingredients" name="ingredient.0.name" placeholder="Ingredient"/>
          - unexpected value "sucre"


      164 |     await ingredients.nth(0).hover();  // Give the drag some more time to land.
      165 |     await page.mouse.up();
    > 166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
          |                                                                          ^
      167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:166:74

Check failure on line 166 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
    Expected string: "Spices"
    Received string: "sucre"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" value="sucre" list="all-ingredients" name="ingredient.0.name" placeholder="Ingredient"/>
          - unexpected value "sucre"


      164 |     await ingredients.nth(0).hover();  // Give the drag some more time to land.
      165 |     await page.mouse.up();
    > 166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
          |                                                                          ^
      167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:166:74

Check failure on line 166 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
    Expected string: "Spices"
    Received string: "sucre"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').first().getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" value="sucre" list="all-ingredients" name="ingredient.0.name" placeholder="Ingredient"/>
          - unexpected value "sucre"


      164 |     await ingredients.nth(0).hover();  // Give the drag some more time to land.
      165 |     await page.mouse.up();
    > 166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
          |                                                                          ^
      167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:166:74
await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");

Check failure on line 167 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
    Expected string: "sucre"
    Received string: "Spices"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" list="all-ingredients" placeholder="Ingredient" name="ingredient.1.name"/>
          - unexpected value "Spices"


      165 |     await page.mouse.up();
      166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
    > 167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
          |                                                                          ^
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
      170 |     // Make sure the form field names are also right.
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:167:74

Check failure on line 167 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
    Expected string: "sucre"
    Received string: "Spices"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" list="all-ingredients" placeholder="Ingredient" name="ingredient.1.name"/>
          - unexpected value "Spices"


      165 |     await page.mouse.up();
      166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
    > 167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
          |                                                                          ^
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
      170 |     // Make sure the form field names are also right.
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:167:74

Check failure on line 167 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
    Expected string: "sucre"
    Received string: "Spices"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for getByRole('group').filter({ has: getByRole('heading', { name: 'Ingredients' }) }).getByRole('listitem').nth(1).getByPlaceholder('Ingredient')
        9 × locator resolved to <input type="text" required="" list="all-ingredients" placeholder="Ingredient" name="ingredient.1.name"/>
          - unexpected value "Spices"


      165 |     await page.mouse.up();
      166 |     await expect.soft(ingredients.nth(0).getByPlaceholder("Ingredient")).toHaveValue("Spices");
    > 167 |     await expect.soft(ingredients.nth(1).getByPlaceholder("Ingredient")).toHaveValue("sucre");
          |                                                                          ^
      168 |     await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");
      169 |
      170 |     // Make sure the form field names are also right.
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:167:74
await expect.soft(ingredients.nth(2).getByPlaceholder("Ingredient")).toHaveValue("pomme");

// Make sure the form field names are also right.
await expect.soft(page.locator('input[name="ingredient.0.name"]')).toHaveValue("Spices");

Check failure on line 171 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('input[name="ingredient.0.name"]')
    Expected string: "Spices"
    Received string: "sucre"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for locator('input[name="ingredient.0.name"]')
        9 × locator resolved to <input type="text" required="" value="sucre" list="all-ingredients" name="ingredient.0.name" placeholder="Ingredient"/>
          - unexpected value "sucre"


      169 |
      170 |     // Make sure the form field names are also right.
    > 171 |     await expect.soft(page.locator('input[name="ingredient.0.name"]')).toHaveValue("Spices");
          |                                                                        ^
      172 |     await expect.soft(page.locator('input[name="ingredient.1.name"]')).toHaveValue("sucre");
      173 |     await expect.soft(page.locator('input[name="ingredient.2.name"]')).toHaveValue("pomme");
      174 |   });
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:171:72

Check failure on line 171 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('input[name="ingredient.0.name"]')
    Expected string: "Spices"
    Received string: "sucre"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for locator('input[name="ingredient.0.name"]')
        9 × locator resolved to <input type="text" required="" value="sucre" list="all-ingredients" name="ingredient.0.name" placeholder="Ingredient"/>
          - unexpected value "sucre"


      169 |
      170 |     // Make sure the form field names are also right.
    > 171 |     await expect.soft(page.locator('input[name="ingredient.0.name"]')).toHaveValue("Spices");
          |                                                                        ^
      172 |     await expect.soft(page.locator('input[name="ingredient.1.name"]')).toHaveValue("sucre");
      173 |     await expect.soft(page.locator('input[name="ingredient.2.name"]')).toHaveValue("pomme");
      174 |   });
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:171:72
await expect.soft(page.locator('input[name="ingredient.1.name"]')).toHaveValue("sucre");

Check failure on line 172 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('input[name="ingredient.1.name"]')
    Expected string: "sucre"
    Received string: "Spices"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for locator('input[name="ingredient.1.name"]')
        9 × locator resolved to <input type="text" required="" list="all-ingredients" placeholder="Ingredient" name="ingredient.1.name"/>
          - unexpected value "Spices"


      170 |     // Make sure the form field names are also right.
      171 |     await expect.soft(page.locator('input[name="ingredient.0.name"]')).toHaveValue("Spices");
    > 172 |     await expect.soft(page.locator('input[name="ingredient.1.name"]')).toHaveValue("sucre");
          |                                                                        ^
      173 |     await expect.soft(page.locator('input[name="ingredient.2.name"]')).toHaveValue("pomme");
      174 |   });
      175 |
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:172:72

Check failure on line 172 in webserver/e2e/edit.spec.ts

View workflow job for this annotation

GitHub Actions / playwright (prod)

[chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients 

  1) [chromium] › e2e/edit.spec.ts:152:3 › Logged in › Can drag ingredients ────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('input[name="ingredient.1.name"]')
    Expected string: "sucre"
    Received string: "Spices"
    Call log:
      - expect.soft.toHaveValue with timeout 5000ms
      - waiting for locator('input[name="ingredient.1.name"]')
        9 × locator resolved to <input type="text" required="" list="all-ingredients" placeholder="Ingredient" name="ingredient.1.name"/>
          - unexpected value "Spices"


      170 |     // Make sure the form field names are also right.
      171 |     await expect.soft(page.locator('input[name="ingredient.0.name"]')).toHaveValue("Spices");
    > 172 |     await expect.soft(page.locator('input[name="ingredient.1.name"]')).toHaveValue("sucre");
          |                                                                        ^
      173 |     await expect.soft(page.locator('input[name="ingredient.2.name"]')).toHaveValue("pomme");
      174 |   });
      175 |
        at /__w/cookbook/cookbook/webserver/e2e/edit.spec.ts:172:72
await expect.soft(page.locator('input[name="ingredient.2.name"]')).toHaveValue("pomme");
});

Expand Down
10 changes: 5 additions & 5 deletions webserver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@
},
"packageManager": "[email protected]+sha256.4b702887986995933d4300836b04d6d02a43bc72b52e4f7e93a4ca608b959197",
"dependencies": {
"@astrojs/node": "^8.3.3",
"@astrojs/solid-js": "^4.4.1",
"@astrojs/node": "^9.1.0",
"@astrojs/solid-js": "^5.0.4",
"@github/relative-time-element": "^4.4.5",
"@google-cloud/storage": "^7.15.2",
"@js-temporal/polyfill": "^0.4.4",
"@prisma/client": "^6.4.1",
"@sentry/astro": "^8.51.0",
"@shoelace-style/shoelace": "^2.20.0",
"age-encryption": "^0.2.1",
"astro": "^4.16.18",
"astro": "^5.3.0",
"debug": "^4.4.0",
"dset": "^3.1.4",
"express": "^4.21.2",
Expand All @@ -50,7 +50,7 @@
"solid-js": "^1.9.5",
"typescript": "^5.7.3",
"unified": "^11.0.5",
"vite": "^5.4.12",
"vite": "^6.1.1",
"zod": "^3.24.2"
},
"devDependencies": {
Expand All @@ -60,6 +60,6 @@
"@types/n3": "^1.21.1",
"@types/node": "^22.13.5",
"dotenv-cli": "^8.0.0",
"vitest": "^2.1.9"
"vitest": "^3.0.6"
}
}
Loading
Loading