add error handling when sending score#53
Draft
ThierryBerger wants to merge 2 commits intovleue:mainfrom
Draft
Conversation
ThierryBerger
commented
Aug 22, 2022
| fn despawn_menu(mut commands: Commands, root_ui: Query<Entity, (With<Node>, Without<Parent>)>) { | ||
| fn despawn_menu( | ||
| mut commands: Commands, | ||
| root_ui: Query<Entity, (With<Node>, With<MenuUI>, Without<Parent>)>, |
Contributor
Author
There was a problem hiding this comment.
I added more control on what exactly is despawned to be able to keep the debug UI for errors display
ThierryBerger
commented
Aug 24, 2022
| .run(); | ||
| } | ||
|
|
||
| mod debug { |
Contributor
Author
There was a problem hiding this comment.
this should be after GameState and setup()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds error handling when sending score.
Rationale
An app might want to retry to send a score if it failed, otherwise the user will be disappointed to see its score not saved :(
I see 2 main reasons for failing to send:
Pull requests attention points