Draft
Conversation
See title. The new React() proc features a smaller code-footprint and hopefully improved readibility. The current new features include support for decaying reactions as well as generic handling of required reactants and products. Also added were maxima for both the temperature and energy level of the reactor for reactions to happen. An improved, but still not complete, distribution system of reactants to reactions should help with making complex systems less random and more probabilistic. Planned for current additions: Fit distribution system to a distribution plot making reactions with more reactants present more likely. Add automatic decay once reactant hits a certain amount to prevent overload.
Adds a boatload of comments. Also updates old reactions. Also adds support back for special handling, woups. Removes unused helpers that didn't wound up necessary. Adds a comment to a debug function to have it be removed before production merge. Also makes checks not be angy by removing .Find because for some reason that's a macro whatever.
Shadowtail117
added
⚖1 Balance
Haha yeah "Tested"
Contributor
Author
|
Forgot to mention this but I'm keeping the super simple key-string-based reactant system because it's so damn easy to modify it's a plus rather than a negative. Seriously, admins, this is bliss to work with to mess with the reactants |
https://en.wikipedia.org/wiki/Stellar_nucleosynthesis Also does miscellanious cleanup and adds a hopefully better sorting of reactions This is probably going to irradiate the entire Torch Also fixes a bug where reactants wouldn't be properly added to the copy. 4 hours......
Collaborator
Collaborator
Collaborator
Collaborator
Test Merge Removed |
Rads rads we're the rads
Collaborator
|
CI is failing on global hash |
Contributor
Author
And it will probably continue to fail as I modify globals with new features |
Explosions can now be rather destructive. Like, really destructive.
Cupax3
force-pushed
the
fusion
branch
5 times, most recently
from
6a2cb3f to
a148b4a
Compare
Haha frick the brig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Pull Request
See title.
The new React() proc features a smaller code-footprint and hopefully improved readibility.
The current new features include support for decaying reactions as well as generic handling of required reactants and products.
Also added were maxima for both the temperature and energy level of the reactor for reactions to happen.
An improved, but still not complete, distribution system of reactants to reactions should help with making complex systems less random and more probabilistic.
Planned for current additions:
Fit distribution system to a distribution plot making reactions with more reactants present more likely.
Add automatic decay once reactant hits a certain amount to prevent overload.
Add an example implementation of the CNO-Cycle.
Planned:
Rework the entire reactant addition and subtraction system to make it semi-tiered and involve multiple departments for high-end stuff.
Remove the lag monster known as gyrotron.
Rework attached machinery to also require more involvement.
Rework science progression to lock high-level stuff behind new materials.
New materials.
Make the RUST actually radioactive
More to be added.
Please add your suggestions in the comments!
Code review appreciated but please bear in mind this is still in-dev.
Why It's Good For The Game
[TBD]
Did you test it?
Yes - WIP
Changelog
[TBD]
🆑
/:cl: