Validates that that image exists for commit #170
+24
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khluu
reviewed
Sep 22, 2025
| DOCKER_IMAGE_OVERRIDE="$IMAGE_TAG" | ||
| echo "Using Docker image for LCA commit: $DOCKER_IMAGE_OVERRIDE" | ||
| else | ||
| DOCKER_IMAGE_OVERRIDE="public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:latest" |
There was a problem hiding this comment.
we don't need this if we don't enable SKIP_IMAGE_BUILD right
There was a problem hiding this comment.
good eye got it, another push incoming...
dougbtv
force-pushed
the
bugfix/validate-image-for-commit
branch
2 times, most recently
from
456a78e to
a9e8e80
Compare
|
test build in: https://buildkite.com/vllm/ci/builds/31858 |
dougbtv
force-pushed
the
bugfix/validate-image-for-commit
branch
from
a9e8e80 to
3a7f26e
Compare
Otherwise, falls back to building image and wheel. Signed-off-by: dougbtv <[email protected]>
dougbtv
force-pushed
the
bugfix/validate-image-for-commit
branch
from
3a7f26e to
1550cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, falls back to building image and wheel.