[Refactor] Rename offload_model to set_onload_device#643
Merged
kylesayrs merged 4 commits intovllm-project:mainfrom Mar 25, 2026
Merged
Conversation
set_onload_device - Add set_onload_device as the canonical function (replaces offload_model) - Deprecate offload_model using @deprecated decorator pointing to set_onload_device - Remove offload_device param from set_onload_device (was already ignored with warning) - Update all internal usages and tests Part of vllm-project/llm-compressor#2483
nrmlthms
changed the title
brian-dellabetta
approved these changes
Mar 23, 2026
Collaborator
brian-dellabetta
left a comment
brian-dellabetta
left a comment
There was a problem hiding this comment.
Thanks for updating the READMEs
kylesayrs
approved these changes
Mar 23, 2026
Collaborator
kylesayrs
left a comment
kylesayrs
left a comment
There was a problem hiding this comment.
Really awesome contribution, thanks!
|
The quality checks have failed. Please run |
Collaborator
|
Hi @nrmlthms, please run |
auto-merge was automatically disabled
March 24, 2026 17:16
Head branch was pushed to by a user without write access
kylesayrs
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_onload_deviceas the canonical replacement foroffload_modeloffload_modelusing the existing@deprecateddecorator, pointing to
set_onload_deviceoffload_deviceparameter fromset_onload_device(was already silently ignored inoffload_model)offloaded_dispatchinutils/offload.pyto callset_onload_deviceset_onload_devicePart of vllm-project/llm-compressor#2483
Companion PR
vllm-project/llm-compressor#2501