add test

Signed-off-by: dalthecow <[email protected]>

Author: DaltheCow

src/guidellm/presentation/data_models.py

@@ -3,9 +3,10 @@
 from math import ceil
 from typing import TYPE_CHECKING, Optional, Union
 
-from guidellm.scheduler.strategy import SchedulingStrategy
 from pydantic import BaseModel, computed_field
 
+from guidellm.scheduler.strategy import SchedulingStrategy
+
 if TYPE_CHECKING:
     from guidellm.benchmark.benchmark import GenerativeBenchmark
 
@@ -215,14 +216,14 @@ class BenchmarkDatum(BaseModel):
     time_per_request: TabularDistributionSummary
     strategy_display_str: str
 
-    def strategy_display_str(strategy: SchedulingStrategy):
+    @classmethod
+    def get_strategy_display_str(cls, strategy: SchedulingStrategy):
         strategy_type = strategy if isinstance(strategy, str) else strategy.type_
-        strategy_instance = strategy if isinstance(strategy, SchedulingStrategy) else None
 
         if strategy_type == "concurrent":
-            rate = f"@{strategy_instance.streams}" if strategy_instance else "@##"  # type: ignore[attr-defined]
+            rate = f"@{strategy.streams}"
         elif strategy_type in ("constant", "poisson"):
-            rate = f"@{strategy_instance.rate:.2f}" if strategy_instance else "@#.##"  # type: ignore[attr-defined]
+            rate = f"@{strategy.rate:.2f}"
         else:
             rate = ""
         return f"{strategy_type}{rate}"
@@ -231,7 +232,7 @@ def strategy_display_str(strategy: SchedulingStrategy):
     def from_benchmark(cls, bm: "GenerativeBenchmark"):
         rps = bm.metrics.requests_per_second.successful.mean
         return cls(
-            strategy_display_str=cls.strategy_display_str(bm.args.strategy),
+            strategy_display_str=cls.get_strategy_display_str(bm.args.strategy),
             requests_per_second=rps,
             tpot=TabularDistributionSummary.from_distribution_summary(
                 bm.metrics.inter_token_latency_ms.successful

tests/unit/presentation/test_data_models.py

@@ -1,6 +1,7 @@
 import pytest
 
-from guidellm.presentation.data_models import Bucket
+from guidellm.presentation.data_models import BenchmarkDatum, Bucket
+from tests.unit.mock_benchmark import mock_generative_benchmark
 
 
 @pytest.mark.smoke
@@ -18,3 +19,10 @@ def test_bucket_from_data():
     assert buckets[1].value == 8.0
     assert buckets[1].count == 5
     assert bucket_width == 1
+
+
+@pytest.mark.smoke
+def test_from_benchmark_includes_strategy_display_str():
+    mock_bm = mock_generative_benchmark()
+    bm = BenchmarkDatum.from_benchmark(mock_bm)
+    assert bm.strategy_display_str == "synchronous"