Skip to content

Fix/non integer rates #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix/non integer rates #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df800a
FIX: Allow rate if either int or float.
thameem-abbas Apr 16, 2025
bad9c1f
FIX: Allow rate if either int or float.
thameem-abbas Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/guidellm/benchmark/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,9 @@ def from_standard_args( # type: ignore[override]
if not isinstance(rate, Sequence):
rate = [rate]

if not all(r.is_integer() and r > 0 for r in rate):
if not all(isinstance(r, (float, int)) and r > 0 for r in rate):
raise ValueError(
f"All rate values must be positive integers, received {rate}"
f"All rate values must be positive numbers, received {rate}"
)

if rate_type == "async":
Expand Down