Skip to content

Conversation

markurtz
Copy link
Collaborator

@markurtz markurtz commented May 1, 2025

No description provided.

@markurtz markurtz self-assigned this May 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the label for the request latency metric in the benchmark console output.

  • Changes the metric label from "Req Latency (ms)" to "Req Latency (sec)".
  • Updates the display tuple for the request latency metric.
Comments suppressed due to low confidence (1)

src/guidellm/benchmark/output.py:892

  • Ensure that the underlying request latency value is also converted from milliseconds to seconds. If the value is still in milliseconds, either convert it or revert the label change.
"Req Latency (sec)": (5, 7),

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14776890501/artifacts/3044683840.
They will be retained for up to 30 days.

@sjmonson sjmonson mentioned this pull request May 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14778713301/artifacts/3045309579.
They will be retained for up to 30 days.

@markurtz markurtz merged commit 4b4ab8e into main May 1, 2025
11 checks passed
@markurtz markurtz deleted the console-output-request-latency-display-fix branch May 1, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants