Restrict rate to only floats #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restricts the rate input strictly to floats to simplify code and address compatibility issues with older Python versions.
- Updated the type annotation for the "rate" parameter in benchmark_generative_text to only allow floats or list of floats.
- Simplified the conversion logic in the CLI parser by removing int conversion in favor of always using float conversion.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/guidellm/benchmark/entrypoints.py | Updated the type annotation for "rate" to restrict to floats. |
| src/guidellm/main.py | Removed int conversion so that number parsing always returns floats. |
Comments suppressed due to low confidence (1)
src/guidellm/benchmark/entrypoints.py:41
- The update to only accept floats for the rate parameter is clear; ensure all related documentation and usage context reflect that the parameter no longer supports integers.
rate: Optional[Union[float, list[float]]],
Co-authored-by: Copilot <[email protected]>
markurtz
previously approved these changes
May 15, 2025
This reverts commit 72300f1.
|
@markurtz the Copilot suggestion is bad since the number can still be an int on the cmdline it will just be interpreted as a float. |
markurtz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already support casting floats to int so to simplify the arg code and solve an issue with older pythons just treat all input as floats.
Fixes #163