add initial app state for development with redux/theming set up #165
Conversation
|
📦 Build Artifacts Available |
There was a problem hiding this comment.
Pull Request Overview
This PR bootstraps the application with Redux, MUI theming, SVG handling, and foundational layouts for development.
- Adds a centralized color palette and shade generator
- Sets up Redux store, theme provider, and layout components
- Configures Jest asset mocks and ESLint import resolution
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/lib/utils/SvgContainer.tsx | Styled wrapper to color SVG paths |
| src/ui/lib/utils/Colors.ts | Defines color constants and generates shades |
| src/ui/lib/utils/ColorHelper.ts | Hex/RGB conversion and shade-mixing utilities |
| src/ui/lib/store/provider.tsx | ReduxProvider component |
| src/ui/lib/store/index.ts | Configures Redux store and default slice |
| src/ui/lib/layouts/helpers/useCurrentBreakpoint.ts | Hook to detect current MUI breakpoint |
| src/ui/lib/layouts/helpers/ContentCenterer.tsx | Centers content with responsive padding |
| src/ui/lib/layouts/FullPageWithHeaderAndFooterLayout.tsx | Layout component with header, body, and footer slots |
| src/ui/lib/components/PageFooter/index.tsx | Re-exports PageFooter component |
| src/ui/lib/components/PageFooter/PageFooter.component.tsx | Footer UI with placeholder Slack link |
| src/ui/jest.config.js | Adds Jest mocks for SVGs, files, and style assets |
| src/ui/app/page.tsx | Home page wired with providers, theme, and layout |
| src/ui/app/layout.tsx | RootLayout with <html> head tags and metadata |
| src/ui/app/globals.css | Global CSS including font-face definitions |
| src/ui/app/assets/icons/index.tsx | Exports SVG icon imports |
| src/ui/mocks/svg.js | Jest mock for SVG imports |
| src/ui/mocks/styleMock.js | Jest mock for style imports |
| src/ui/mocks/fileMock.js | Jest mock for other file imports |
| src/ui/.eslintrc.json | Enhanced import/order and TypeScript resolver |
| package.json | Updated dependencies, scripts, and removed private flag |
Comments suppressed due to low confidence (3)
src/ui/lib/store/index.ts:17
- Using
defaultas the reducer key is ambiguous. Rename the slice key to something more descriptive likemodelordefaultModel.
default: defaultSlice.reducer,
src/ui/jest.config.js:19
- Duplicate mapping for
^@/(.*)$will override the earlier'<rootDir>/src/$1'mapping. Remove the redundant entry or merge paths to avoid incorrect module resolution.
'^@/(.*)$': '<rootDir>/$1',
package.json:3
- The
privatefield was removed frompackage.json, which may allow accidental publishing to npm. Consider re-adding"private": trueif this package shouldn’t be published.
"version": "0.1.0",
There was a problem hiding this comment.
Ran through review, a few comments to run through Ben. Also, for public methods, especially utility functions, can we include some basic docs for those? Even auto generated from an LLM would work to give a bit more context on the purpose and expected args / returns. Finally, can we move the tests under guidellm/tests/ui instead of nesting them under src to have better separation of application code and test code?
|
📦 Build Artifacts Available |
simplify/use next conventions in <Head> tag Co-authored-by: Copilot <[email protected]>
|
📦 Build Artifacts Available |
…lm into implement-app-tooling
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
2 participants
This sets up the app with mui and redux dependencies, implements the theme and configures svgs along with other related pieces. This is the base of what is needed for development. The remainder will just be app specific pieces such as charts and implementing the rest of the application.
I think the main thing that can be slotted in here is branding with the GuideLLM Logo since this PR originally introduced the old NM branding. Not my highest priority right now but happy to fix in this PR.