-
Notifications
You must be signed in to change notification settings - Fork 89
fix links check fail, remove speculators from docs #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaltheCow! The big issue that is happening behind the scenes is that we're getting rate-limited by GitHub on checks, and the link checking software doesn't have any ability for us to apply a rate limit to it (in combination with GitHub not returning proper wait until headers). So I was going to migrate to a new tool that we could control, which would also pass in GitHub auth credentials to increase the potential rate at which we can hit GitHub. For now, though, the updates to the links are good catches, and if we can update it to just wipe out the link checks until we can get the new tool in, that would be perfect. I'd rather wipe out the tool than hardcode skipping of all GitHub links, so we don't have a false sense of security reported, since most of the links will be GitHub ones. I can update a bit later, but if you can get to it, that would be perfect and I can rereview
Sounds good! Will do that |
📦 Build Artifacts Available |
I removed it from the development and main workflows and left it in the others, thinking we might want to leave those as failing until this can be resolved. |
We are getting link-check fails on the github rich display links. Not sure what the desired solution is but this gets the check passing by ignoring links like that.
Also we have what look to be some pasted doc remnants from the speculators repo so I changed everything saying speculators to guidellm