Skip to content

Bug fixes #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

Bug fixes #173

merged 2 commits into from
May 29, 2025

Conversation

dagrayvid
Copy link
Collaborator

This PR fixes two small bugs.

  • Double counting of prompt tokens in the calculation of total tokens_per_second
  • The warmup percent was not working when using max duration (worked for max requests). Traced this to a - which should have been a + in benchmark/aggregator.py

@dagrayvid dagrayvid requested a review from markurtz May 27, 2025 15:19
@markurtz markurtz merged commit 66017f5 into vllm-project:main May 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markurtz markurtz markurtz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagrayvid @markurtz