Skip to content

Improve pre-commit usablity for local development #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Improve pre-commit usablity for local development #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77406bb
Enable formatting and auto fixing in pre-commit
sjmonson Jun 5, 2025
bcb7ef5
Skip formatting step in workflow pre-commit
sjmonson Jun 5, 2025
af568a1
Show fixed lintting errors
sjmonson Jun 5, 2025
2dfaf9d
Merge branch 'main' into feat/pre_commit_improve
markurtz Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Install dependencies
run: pip install pre-commit
- name: Run pre-commit checks
run: pre-commit run --all-files
run: SKIP=ruff-format pre-commit run --all-files

ui-precommit-check:
permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Install dependencies
run: pip install pre-commit
- name: Run pre-commit checks
run: pre-commit run --all-files
run: SKIP=ruff-format pre-commit run --all-files

unit-tests:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ repos:
rev: v0.11.7
hooks:
- id: ruff
name: run linter
args: [ --fix, --show-fixes ]
- id: ruff-format
name: run formatter
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.15.0
hooks:
Expand Down