Run development workflow from target branch scope #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmonson
changed the title
sjmonson
force-pushed
the
fix/build_external_failure
branch
from
db914fa to
d72f086
Compare
sjmonson
changed the title
sjmonson
force-pushed
the
fix/build_external_failure
branch
from
d72f086 to
23221ef
Compare
sjmonson
changed the title
sjmonson
force-pushed
the
fix/build_external_failure
branch
8 times, most recently
from
220a463 to
370c142
Compare
sjmonson
force-pushed
the
fix/build_external_failure
branch
from
370c142 to
e5972be
Compare
|
I have spent way too much time trying to figure out why the checks will not trigger and I think the answer is that this PR must be merged into main and then can be tested from the next PR. (ref) |
sjmonson
changed the title
sjmonson
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development workflow trigger to use pull_request_target so that the workflow runs from the target branch scope, addressing the permission failure in the build job.
- Updated workflow trigger from "pull_request" to "pull_request_target"
- Adjusted event types to maintain appropriate workflow behavior
markurtz
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the development workflow on the
pull_request_targettrigger which runs the workflow from the scope of the target branch rather than the merge branch. This should solve the permission failure in the build job.