Skip to content

Conversation

git-jxj
Copy link
Contributor

@git-jxj git-jxj commented Sep 12, 2025

Summary

"I propose setting /v1/chat/completions as the default route. This would align the tool with current industry best practices, where the chat
completions endpoint is the definitive standard. It streamlines the setup for the vast majority of users, while ensuring backward compatibility is
maintained for the minority who rely on the legacy /v1/completions endpoint, as they can opt-in to the old behavior by setting
GUIDELLM__PREFERRED_ROUTE="text_completions"."

Details

  • [ ]

Test Plan

I have manually verified the changes:

  1. Ran guidellm benchmark without any environment variables and confirmed via logs that it now correctly targets the /v1/chat/completions endpoint.
  2. Ran guidellm benchmark with export GUIDELLM__PREFERRED_ROUTE="text_completions" and confirmed it successfully falls back to the /v1/completions endpoint.

Related Issues

#324

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson
Copy link
Collaborator

Won't Do. See #324

@sjmonson sjmonson closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants