Skip to content

Conversation

markurtz
Copy link
Collaborator

Summary

Renames config.py to settings.py for better semantic clarity particularly with later config pathways and updates project dependencies.

Details

  • Module Refactor: Renamed src/guidellm/config.py to settings.;pyand updated all import references across the codebase
  • Dependency Updates:
    • Added new dependencies: culsanseval_type_backportfakermsgpackpyhumpssanicuvloop
    • Updated pytest-asyncio from ~=0.23.8 to ~=1.1.0
    • Removed recommended optional dependencies section
    • Removed [dependency-groups] and [tool.pdm] sections
  • Configuration Improvements:
    • Reformatted license specification to use {text = "Apache-2.0"} format
    • Added target-version = "py39" to Ruff configuration
    • Improved code formatting and comment alignment in pyproject.toml
    • Enhanced Ruff ignore rules with better documentation
    • Fixed trailing comma in pytest markers
  • Import Organization: Updated import order in __init__.py to import logger before settings for better dependency flow

Test Plan

  • Automated tests are passing

Related Issues

N/A


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

…ng config.py to settings.py due to later config additions and potential conflicts in naming

Signed-off-by: Mark Kurtz <[email protected]>
@markurtz markurtz force-pushed the features/refactor/core branch from 843330d to 669848d Compare September 19, 2025 03:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the configuration module from config.py to settings.py and updates project dependencies and tooling accordingly.

  • Replace imports from guidellm.config with guidellm.settings across the codebase
  • Bump and add dependencies in pyproject.toml and adjust tooling (Ruff target version, pytest marker formatting)
  • Reorder imports in init.py so logger is imported before settings

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/unit/test_logger.py Update imports to use guidellm.settings.LoggingSettings
tests/unit/test_config.py Update imports to use guidellm.settings.*
tests/unit/presentation/test_injector.py Swap settings import to guidellm.settings
tests/unit/backend/test_openai_backend_custom_configs.py Update settings import path
tests/unit/backend/test_openai_backend.py Update settings import path
src/guidellm/utils/text.py Update settings import path
src/guidellm/scheduler/strategy.py Update settings import path
src/guidellm/scheduler/scheduler.py Move settings import and update path
src/guidellm/request/loader.py Update settings import path
src/guidellm/presentation/injector.py Update settings import path
src/guidellm/logger.py Update imports to use settings and minor formatting adjustment
src/guidellm/benchmark/profile.py Update settings import path
src/guidellm/benchmark/output.py Update settings import path
src/guidellm/benchmark/aggregator.py Update settings import path
src/guidellm/backend/response.py Update settings import path
src/guidellm/backend/openai.py Update settings import path
src/guidellm/backend/backend.py Update settings import path
src/guidellm/main.py Update print_config import to guidellm.settings
src/guidellm/init.py Reorder and update exports to import from settings
setup.py Update LAST_RELEASE_VERSION baseline
pyproject.toml Dependency updates, tooling configuration tweaks, and formatting
Comments suppressed due to low confidence (1)

src/guidellm/logger.py:49

  • The default argument captures settings.logging at import time, which can lead to stale defaults if settings are reloaded or modified later. Prefer def configure_logger(config: LoggingSettings | None = None) and set config = config or settings.logging inside the function to evaluate the default at call time.
def configure_logger(config: LoggingSettings = settings.logging):

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sjmonson
Copy link
Collaborator

  • Removed recommended optional dependencies section
  • Removed [dependency-groups] and [tool.pdm] sections

Why? Both of these are recent additions that we use.

Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Also waiting on other PR merges.

sjmonson added a commit that referenced this pull request Sep 23, 2025
[GuideLLM Refactor] core updates for pyproject.toml and settings.py #352
@markurtz
Copy link
Collaborator Author

  • Removed recommended optional dependencies section
  • Removed [dependency-groups] and [tool.pdm] sections

Why? Both of these are recent additions that we use.

Wasn't intentional, missed since it had landed after the latest starting state for the refactor. Fixed now

@markurtz markurtz requested a review from sjmonson September 24, 2025 09:00
@markurtz markurtz force-pushed the features/refactor/core branch from 34b24ea to 669848d Compare September 24, 2025 09:55
@markurtz
Copy link
Collaborator Author

See above. Also waiting on other PR merges.

Ah, never mind, reverted, didn't see the PRs you opened up

## Summary

<!--
Include a short paragraph of the changes introduced in this PR.
If this PR requires additional context or rationale, explain why
the changes are necessary.
-->

TODO

---

- [x] "I certify that all code in this PR is my own, except as noted
below."

## Use of AI

- [ ] Includes AI-assisted code completion
- [ ] Includes code generated by an AI application
- [ ] Includes AI-generated tests (NOTE: AI written tests should have a
docstring that includes `## WRITTEN BY AI ##`)
sjmonson added a commit that referenced this pull request Sep 25, 2025
@markurtz markurtz changed the base branch from main to features/refactor/base September 29, 2025 14:15
@markurtz markurtz merged commit 3f1ff7a into features/refactor/base Sep 29, 2025
15 of 17 checks passed
@markurtz markurtz deleted the features/refactor/core branch September 29, 2025 14:18
@markurtz markurtz added this to the v0.4.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants