-
Notifications
You must be signed in to change notification settings - Fork 86
[GuideLLM Refactor] core updates for pyproject.toml and settings.py #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… refactor branch Signed-off-by: Mark Kurtz <[email protected]>
…ng config.py to settings.py due to later config additions and potential conflicts in naming Signed-off-by: Mark Kurtz <[email protected]>
Signed-off-by: Mark Kurtz <[email protected]>
843330d
to
669848d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors the configuration module from config.py to settings.py and updates project dependencies and tooling accordingly.
- Replace imports from guidellm.config with guidellm.settings across the codebase
- Bump and add dependencies in pyproject.toml and adjust tooling (Ruff target version, pytest marker formatting)
- Reorder imports in init.py so logger is imported before settings
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/unit/test_logger.py | Update imports to use guidellm.settings.LoggingSettings |
tests/unit/test_config.py | Update imports to use guidellm.settings.* |
tests/unit/presentation/test_injector.py | Swap settings import to guidellm.settings |
tests/unit/backend/test_openai_backend_custom_configs.py | Update settings import path |
tests/unit/backend/test_openai_backend.py | Update settings import path |
src/guidellm/utils/text.py | Update settings import path |
src/guidellm/scheduler/strategy.py | Update settings import path |
src/guidellm/scheduler/scheduler.py | Move settings import and update path |
src/guidellm/request/loader.py | Update settings import path |
src/guidellm/presentation/injector.py | Update settings import path |
src/guidellm/logger.py | Update imports to use settings and minor formatting adjustment |
src/guidellm/benchmark/profile.py | Update settings import path |
src/guidellm/benchmark/output.py | Update settings import path |
src/guidellm/benchmark/aggregator.py | Update settings import path |
src/guidellm/backend/response.py | Update settings import path |
src/guidellm/backend/openai.py | Update settings import path |
src/guidellm/backend/backend.py | Update settings import path |
src/guidellm/main.py | Update print_config import to guidellm.settings |
src/guidellm/init.py | Reorder and update exports to import from settings |
setup.py | Update LAST_RELEASE_VERSION baseline |
pyproject.toml | Dependency updates, tooling configuration tweaks, and formatting |
Comments suppressed due to low confidence (1)
src/guidellm/logger.py:49
- The default argument captures settings.logging at import time, which can lead to stale defaults if settings are reloaded or modified later. Prefer def configure_logger(config: LoggingSettings | None = None) and set config = config or settings.logging inside the function to evaluate the default at call time.
def configure_logger(config: LoggingSettings = settings.logging):
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Why? Both of these are recent additions that we use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above. Also waiting on other PR merges.
[GuideLLM Refactor] core updates for pyproject.toml and settings.py #352
Wasn't intentional, missed since it had landed after the latest starting state for the refactor. Fixed now |
34b24ea
to
669848d
Compare
Ah, never mind, reverted, didn't see the PRs you opened up |
## Summary <!-- Include a short paragraph of the changes introduced in this PR. If this PR requires additional context or rationale, explain why the changes are necessary. --> TODO --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes AI-assisted code completion - [ ] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`)
…352\n\nfeatures/refactor/core
Summary
Renames
config.py
tosettings.py
for better semantic clarity particularly with later config pathways and updates project dependencies.Details
src/guidellm/config.py
tosettings.;py
and updated all import references across the codebaseculsans
,eval_type_backport
,faker
,msgpack
,pyhumps
,sanic
,uvloop
pytest-asyncio
from~=0.23.8
to~=1.1.0
recommended
optional dependencies section[dependency-groups]
and[tool.pdm]
sections{text = "Apache-2.0"}
formattarget-version = "py39"
to Ruff configuration__init__.py
to import logger before settings for better dependency flowTest Plan
Related Issues
N/A
Use of AI
## WRITTEN BY AI ##
)