Skip to content

[GuideLLM Refactor] Edge case errors #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

[GuideLLM Refactor] Edge case errors #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feefe65
Fix errors that pop up when there are no successful requests
jaredoconnell Sep 29, 2025
f8810e8
Fix grammatical error
jaredoconnell Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/guidellm/benchmark/aggregator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ def __call__(

def compile(
self, state: AggregatorState, scheduler_state: SchedulerState
) -> dict[Literal["scheduler_stats"], BenchmarkSchedulerStats]:
) -> dict[Literal["run_stats"], BenchmarkSchedulerStats]:
"""
Compile scheduler timing metrics into benchmark statistics.

Expand Down Expand Up @@ -473,7 +473,7 @@ def compile(
key="worker_resolve_time", type_="avg", default=0.0
),
worker_resolve_end_delay_avg=state.get_metric(
key="worker_resolve_end_delay", type_="avg"
key="worker_resolve_end_delay", type_="avg", default=0.0
),
finalized_delay_avg=state.get_metric(
key="finalized_delay", type_="avg", default=0.0
Expand Down
3 changes: 2 additions & 1 deletion src/guidellm/benchmark/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,8 @@ def next_strategy(
self.throughput_rate = (
prev_benchmark.metrics.requests_per_second.successful.mean
)
if self.synchronous_rate <= 0 and self.throughput_rate <= 0:
raise RuntimeError("Invalid rates in sweep; aborting. Were there any successful requests?")
self.measured_rates = list(
np.linspace(
self.synchronous_rate,
Expand All @@ -698,7 +700,6 @@ def next_strategy(
if strat.type_ == self.strategy_type
]
)

if self.strategy_type == "constant":
return AsyncConstantStrategy(
rate=self.measured_rates[next_rate_index],
Expand Down
Loading