[GuideLLM Refactor] Features/refactor fix html #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared O'Connell <[email protected]>
Signed-off-by: Jared O'Connell <[email protected]>
markurtz
approved these changes
Sep 30, 2025
This removes reliance on the library pyhumps converting dicts keys from snake_case to camelCase for use in the UI --------- Signed-off-by: dalthecow <[email protected]> Signed-off-by: Samuel Monson <[email protected]> Signed-off-by: Jared O'Connell <[email protected]> Co-authored-by: Samuel Monson <[email protected]> Co-authored-by: Jared O'Connell <[email protected]>
sjmonson
requested changes
Sep 30, 2025
Co-authored-by: Samuel Monson <[email protected]> Signed-off-by: Jared O'Connell <[email protected]>
sjmonson
approved these changes
Sep 30, 2025
jaredoconnell
merged commit 89113d8
into
vllm-project:features/refactor/base
8 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HTML output in the refactor branch.
Details
This PR updates the references for the new data, and corrects a problem that prevented the injection of the data into the HTML. They broke in the refactor.
Here is a screenshot of the current output using this branch:
There will be a follow up PR to make HTML and CSV outputs default in the CLI.
Test Plan
To test this you need to locally host the web server as defined in the readme, then run the following command, with variables replaced for your setup:
guidellm benchmark run --target <your target> --data "prompt_tokens=256,output_tokens=128" --rate-type constant --rate 2 --max-seconds 10 --output-path <your output path> --output-formats htmlUse of AI
## WRITTEN BY AI ##)