Skip to content

Container CI bugfix and disable dry-run on image cleaner #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

Container CI bugfix and disable dry-run on image cleaner #379

merged 3 commits into from
Sep 30, 2025

Conversation

@sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Sep 29, 2025

Summary

Final pieces needed for image CI work. Fully enables auto latest, stable tags and old image pruning.

Details

  • Add pipefail to list-tags command to catch failures
  • Add missing ghcr.io/ to skopeo commands
  • Disable dry-run option for development image cleanup job

Test Plan

Ran with workflow_dispatch see here

2025-09-29T15-45-39 2025-09-29T15-46-02
  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson
Better error handling and add missing FQDN
38f4a8f 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Use repo scope
aa436fb 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Disable dry run
7c32780 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson requested a review from Copilot September 29, 2025 19:59
Copilot AI reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI issues in the container maintenance workflow by adding proper error handling, correcting registry URLs, and enabling automatic cleanup of old development images.

  • Adds pipefail to catch command failures in the tag listing process
  • Fixes missing ghcr.io/ prefix in skopeo commands for proper registry authentication
  • Enables automatic cleanup by disabling dry-run mode for the image retention policy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sjmonson sjmonson requested a review from markurtz September 29, 2025 20:00
@sjmonson sjmonson merged commit f8f6f9d into main Sep 30, 2025
19 checks passed
@sjmonson sjmonson deleted the feat/container_ci_debug branch September 30, 2025 14:21
sjmonson added a commit that referenced this pull request Oct 17, 2025
@sjmonson
Squashed commit of the following:
84bc3d8 
commit 121dcdc
Author: Samuel Monson <[email protected]>
Date:   Fri Oct 10 09:36:09 2025 -0400

    Configurable max_tokens/max_completion_tokens key (#399)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->

    Makes the `max_tokens` request key configurable through an environment
    variable per endpoint type. Defaults to `max_tokens` for legacy
    `completions` and `max_completion_tokens` for `chat/completions`

    ## Details

    <!--
    Provide a detailed list of all changes introduced in this pull request.
    -->
    - Add the `GUIDELLM__OPENAI__MAX_OUTPUT_KEY` config option which is a
    dict mapping from route name -> output tokens key. Default is
    `{"text_completions": "max_tokens", "chat_completions":
    "max_completion_tokens"}`

    ## Test Plan

    <!--
    List the steps needed to test this PR.
    -->
    -

    ## Related Issues

    <!--
    Link any relevant issues that this PR addresses.
    -->
    - Closes #395
    - Closes #269
    - Related #210

    ---

    - [x] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    ---------

    Signed-off-by: Tyler Michael Smith <[email protected]>
    Signed-off-by: Samuel Monson <[email protected]>
    Co-authored-by: Tyler Michael Smith <[email protected]>

commit a24a22d
Author: Samuel Monson <[email protected]>
Date:   Thu Oct 9 15:57:19 2025 -0400

    Fix typo in CI (#401)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->

    ## Details

    <!--
    Provide a detailed list of all changes introduced in this pull request.
    -->
    - [ ]

    ## Test Plan

    <!--
    List the steps needed to test this PR.
    -->
    -

    ## Related Issues

    <!--
    Link any relevant issues that this PR addresses.
    -->
    - Resolves #

    ---

    - [ ] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    Signed-off-by: Samuel Monson <[email protected]>

commit 81af01b
Author: Samuel Monson <[email protected]>
Date:   Thu Oct 9 15:53:45 2025 -0400

    Fix the failing CI again (#400)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->

    ## Details

    <!--
    Provide a detailed list of all changes introduced in this pull request.
    -->
    - [ ]

    ## Test Plan

    <!--
    List the steps needed to test this PR.
    -->
    -

    ## Related Issues

    <!--
    Link any relevant issues that this PR addresses.
    -->
    - Resolves #

    ---

    - [ ] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    Signed-off-by: Samuel Monson <[email protected]>

commit 90a05ab
Author: Samuel Monson <[email protected]>
Date:   Thu Oct 9 14:26:50 2025 -0400

    Fix for container rc tag (Attempt 2) (#398)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->
    This is the same fix as #389 but applied to the RC workflow rather than
    the release workflow as was the original intent with #389. Both
    workflows need this change so not reverting the other one.

    ---

    - [x] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    Signed-off-by: Samuel Monson <[email protected]>

commit 000b39e
Author: Samuel Monson <[email protected]>
Date:   Fri Oct 3 17:46:04 2025 -0400

    Fix for container rc tag (#389)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->
    Fix to parsing rc ref in CI

    ---

    - [x] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    Signed-off-by: Samuel Monson <[email protected]>

commit 108a657
Author: Benjamin Blue <[email protected]>
Date:   Fri Oct 3 10:35:32 2025 -0400

    update tpot to itl in labels and code use (#386)

    ## Summary

    We want to use ITL instead of TPOT. The data we had previously happened
    to be ITL data, but all of the labels indicate that it is TPOT data. Now
    the code and labels reflect that it is ITL data.

    ## Test Plan

    - Everything works, tests pass, No use of TPOT in the UI

    ---------

    Signed-off-by: dalthecow <[email protected]>
    Co-authored-by: Samuel Monson <[email protected]>

commit b1b1b78
Author: Benjamin Blue <[email protected]>
Date:   Wed Oct 1 13:14:47 2025 -0400

    update default build values to use versioned builds (#310)

    ## Summary

    With the default path referring to the versioned build now, users will
    no longer experience their html reports breaking randomly when the build
    files are updated.

    Also fixed versioned build directory path issue that I missed previously

    ---------

    Signed-off-by: dalthecow <[email protected]>

commit 5c9982a
Merge: ad25e06 2c0d993
Author: Mark Kurtz <[email protected]>
Date:   Wed Oct 1 08:23:27 2025 -0400

    first benchark testing example (#328)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->
    <img width="1757" height="1212" alt="image"
    src="https://github.com/user-attachments/assets/fbfddeac-ca56-40c0-b7ae-d2f17d50823a"
    />

    ## Details

    <!--
    Provide a detailed list of all changes introduced in this pull request.
    -->
    - [ ]

    ## Test Plan

    <!--
    List the steps needed to test this PR.
    -->
    -

    ## Related Issues

    <!--
    Link any relevant issues that this PR addresses.
    -->
    - Resolves #

    ---

    - [ ] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

commit 2c0d993
Merge: d1297fe ad25e06
Author: Mark Kurtz <[email protected]>
Date:   Wed Oct 1 08:20:10 2025 -0400

    Merge branch 'main' into example_simulator

commit ad25e06
Merge: f8f6f9d c32896c
Author: Mark Kurtz <[email protected]>
Date:   Wed Oct 1 08:19:59 2025 -0400

    Add formatting to json file with metrics (#372)

    ## Summary

    It's inconvenient to look at metrics.

    ## Details

    -

    ## Test Plan

    - code launch

    ## Related Issues

    - Resolves ##371

    ---

    - [x] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

commit d1297fe
Merge: 8159ca7 f8f6f9d
Author: Mark Kurtz <[email protected]>
Date:   Wed Oct 1 08:17:36 2025 -0400

    Merge branch 'main' into example_simulator

commit c32896c
Merge: 0701389 f8f6f9d
Author: Mark Kurtz <[email protected]>
Date:   Wed Oct 1 08:14:35 2025 -0400

    Merge branch 'main' into add_json_formatiing

commit f8f6f9d
Author: Samuel Monson <[email protected]>
Date:   Tue Sep 30 10:21:54 2025 -0400

    Container CI bugfix and disable dry-run on image cleaner (#379)

    ## Summary

    <!--
    Include a short paragraph of the changes introduced in this PR.
    If this PR requires additional context or rationale, explain why
    the changes are necessary.
    -->
    Final pieces needed for image CI work. Fully enables auto `latest`,
    `stable` tags and old image pruning.

    ## Details

    <!--
    Provide a detailed list of all changes introduced in this pull request.
    -->
    - Add `pipefail` to list-tags command to catch failures
    - Add missing `ghcr.io/` to skopeo commands
    - Disable dry-run option for development image cleanup job

    ## Test Plan

    Ran with `workflow_dispatch` [see
    here](https://github.com/vllm-project/guidellm/actions/runs/18108553536)

    <img width="2032" height="955" alt="2025-09-29T15-45-39"
    src="https://github.com/user-attachments/assets/b981ab01-fe90-4e15-bf60-cb483508065e"
    />
    <img width="1204" height="579" alt="2025-09-29T15-46-02"
    src="https://github.com/user-attachments/assets/68118168-2e80-4d45-92cc-47badc1caf16"
    />

    ---

    - [x] "I certify that all code in this PR is my own, except as noted
    below."

    ## Use of AI

    - [ ] Includes AI-assisted code completion
    - [ ] Includes code generated by an AI application
    - [ ] Includes AI-generated tests (NOTE: AI written tests should have a
    docstring that includes `## WRITTEN BY AI ##`)

    ---------

    Signed-off-by: Samuel Monson <[email protected]>

commit 0701389
Author: psydok <[email protected]>
Date:   Thu Sep 25 23:14:36 2025 +0500

    Add formatting to json file with metrics

    Signed-off-by: psydok <[email protected]>

commit 8159ca7
Author: guangli.bao <[email protected]>
Date:   Mon Sep 15 12:07:08 2025 +0800

    first draft

    Signed-off-by: guangli.bao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@markurtz markurtz markurtz approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjmonson @markurtz @jaredoconnell