Skip to content

fix inconsistent use of abbreviations in ui #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix inconsistent use of abbreviations in ui #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ui/lib/components/MetricsSummary/MetricsSummary.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const Component = () => {
<FieldsContainer data-id="fields-container">
<FieldCell data-id="field-cell-1">
<Input
label="TTFT (ms)"
label="TIME TO FIRST TOKEN (ms)"
value={ttftSLO}
onChange={handleTtft}
fullWidth
Expand All @@ -133,7 +133,7 @@ export const Component = () => {
</FieldCell>
<FieldCell data-id="field-cell-2">
<Input
label="ITL (ms)"
label="INTER-TOKEN LATENCY (ms)"
value={itlSLO}
onChange={handleItl}
fullWidth
Expand Down Expand Up @@ -212,7 +212,7 @@ export const Component = () => {
</MiddleColumn>
<MiddleColumn item xs={3}>
<MetricValue
label="TTFT"
label="time to first token"
value={`${formatNumber(interpolatedMetricData.ttft.enforcedPercentileValue)} ms`}
match={isTtftMatch}
valueColor={LineColor.Primary}
Expand All @@ -230,7 +230,7 @@ export const Component = () => {
</MiddleColumn>
<MiddleColumn item xs={3}>
<MetricValue
label="ITL"
label="inter-token latency"
value={`${formatNumber(interpolatedMetricData.itl.enforcedPercentileValue)} ms`}
match={isItlMatch}
valueColor={LineColor.Secondary}
Expand Down
18 changes: 9 additions & 9 deletions src/ui/lib/components/WorkloadMetrics/WorkloadMetrics.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,49 +57,49 @@ export const Component = () => {
<BlockHeader label="Metrics Details" />
<Box display="flex" flexDirection="row" gap={3} mt={3}>
<MetricsContainer
header="TTFT"
header="TIME TO FIRST TOKEN"
leftColumn={leftColumn(
formattedRequestRate,
formatNumber(ttftAtRPS.mean),
'ms'
)}
rightColumn={columnContent(formattedRequestRate, ttftAtRPS.percentiles, 'ms')}
>
<GraphTitle title="TTFS vs RPS" />
<GraphTitle title="Time to First Token vs RPS" />
<GraphsWrapper>
<DashedLine
data={ttft}
margins={{ left: 50, bottom: 50 }}
xLegend="request per sec"
yLegend="ttft (ms)"
yLegend="time to first token (ms)"
minX={minX}
/>
</GraphsWrapper>
</MetricsContainer>
<MetricsContainer
header="ITL"
header="INTER-TOKEN LATENCY"
leftColumn={leftColumn3(
formattedRequestRate,
formatNumber(itlAtRPS.mean),
'ms'
)}
rightColumn={columnContent(formattedRequestRate, itlAtRPS.percentiles, 'ms')}
>
<GraphTitle title="ITL vs RPS" />
<GraphTitle title="Inter-token Latency vs RPS" />
<GraphsWrapper>
<DashedLine
data={itl}
margins={{ left: 50, bottom: 50 }}
xLegend="request per sec"
yLegend="itl (ms)"
yLegend="inter-token latency (ms)"
minX={minX}
/>
</GraphsWrapper>
</MetricsContainer>
</Box>
<Box display="flex" flexDirection="row" gap={3} mt={3}>
<MetricsContainer
header="E2E Latency"
header="Time Per Request"
leftColumn={leftColumn(
formattedRequestRate,
formatNumber(timePerRequestAtRPS.mean),
Expand All @@ -111,13 +111,13 @@ export const Component = () => {
's'
)}
>
<GraphTitle title="E2E Latency vs RPS" />
<GraphTitle title="Time Per Request vs RPS" />
<GraphsWrapper>
<DashedLine
data={timePerRequest}
margins={{ left: 50, bottom: 50 }}
xLegend="request per sec"
yLegend="latency (s)"
yLegend="time per request (s)"
minX={minX}
/>
</GraphsWrapper>
Expand Down