Indicate max_concurrency for throughput and disallow running standalone without --rate #467
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmonson
force-pushed
the
feat/throughput_track_conc
branch
from
903fe9a to
bb95d1b
Compare
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
force-pushed
the
feat/throughput_track_conc
branch
from
d98b219 to
93d2956
Compare
jaredoconnell
approved these changes
Nov 20, 2025
Collaborator
jaredoconnell
left a comment
jaredoconnell
left a comment
There was a problem hiding this comment.
This works for me if this is the direction we want to go. I like that it specifies the max concurrency in the identifier. And I do prefer the value be passed in there rather than with an env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a indicator to throughput similar to concurrent's
concurrent@CONC. Additionally require specifying--ratefor throughput when running standalone rather than defaulting toMAX_CONCURRENCY.Use of AI
## WRITTEN BY AI ##)