Skip to content

Conversation

@sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Nov 18, 2025

Summary

Deduplicates much of the CI code by defining shared workflows and composite actions. Included in this is fixing some breakage introduced with #440

Details

This PR mostly keeps the same functionally as before with the main exception being pytest markers (when set) are now uniformly applied to all tests jobs.

After this is approved the required CI list needs to be updates to enable merging.

Some follow-up work (post this PR):

  • Deduplicate build and publish actions
  • Enable caching for shared workflow actions (such as pip installs, container builds)
  • Reduce coverage for certain stages
    • E.g. Run subset of tests on PRs

Test Plan

  • See CI runs on this PR for results

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson sjmonson marked this pull request as ready for review November 18, 2025 23:11
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 10d7586 to 105218b Compare November 18, 2025 23:12
@sjmonson sjmonson marked this pull request as draft November 18, 2025 23:16
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 105218b to 5419f46 Compare November 18, 2025 23:32
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 105fffd to 1ced2ce Compare November 19, 2025 16:19
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 2181650 to 1f2115d Compare November 19, 2025 19:27
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 1f2115d to 093ddf0 Compare November 19, 2025 19:35
@sjmonson sjmonson marked this pull request as ready for review November 19, 2025 20:23
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the fix/ci_v0.4.0_failures branch from 8d34fbc to 509c051 Compare November 21, 2025 19:53
Copy link
Collaborator

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants