Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
dsikka
reviewed
Jan 24, 2025
brian-dellabetta
previously approved these changes
Jan 24, 2025
Collaborator
brian-dellabetta
left a comment
brian-dellabetta
left a comment
There was a problem hiding this comment.
left a comment but LGTM otherwise
horheynm
dismissed stale reviews from brian-dellabetta and kylesayrs
via
08ce927
brian-dellabetta
approved these changes
Jan 24, 2025
dsikka
approved these changes
Jan 24, 2025
rahul-tuli
pushed a commit
that referenced
this pull request
Jan 28, 2025
SUMMARY: Nightly tests uses gpus, ci tests dont. In the set up of `tests/llmcompressor/transformers/obcq/test_consecutive_runs.py`, a bug was found where `quantization_config` was always passed. This will result in an error if the model from the config file is not optimized. We are passing in dense model, so it fails. TEST PLAN: Run the failing test, make sure it passes! Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Nightly tests uses gpus, ci tests dont.
In the set up of
tests/llmcompressor/transformers/obcq/test_consecutive_runs.py, a bug was found wherequantization_configwas always passed. This will result in an error if the model from the config file is not optimized.We are passing in dense model, so it fails.
TEST PLAN:
Run the failing test, make sure it passes!