Closed
Conversation
added 5 commits
February 11, 2025 08:07
…odelArguments to post_train
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
added 2 commits
February 11, 2025 08:49
horheynm
commented
Feb 11, 2025
| or self.run_type == StageRunType.POST_TRAIN | ||
| ): | ||
| return self.run_type | ||
| if StageRunType.POST_TRAIN.value in self.group: |
Author
There was a problem hiding this comment.
flip the order check if the config_name has "post_train" first before "train".
horheynm
commented
Feb 11, 2025
| max_seq_length=MAX_SEQ_LENGTH, | ||
| num_calibration_samples=NUM_CALIBRATION_SAMPLES, | ||
| save_compressed=SAVE_COMPRESSED, | ||
| overwrite_output_dir=True, |
Author
There was a problem hiding this comment.
Only used in training args, not post-train dep args. Will raise an error if present
Collaborator
|
we should be landing the entrypoint updates, independent of changing the naming from oneshot to post_train. |
kylesayrs
reviewed
Mar 18, 2025
| main(model_args, data_args, recipe_args, training_args) | ||
|
|
||
|
|
||
| def oneshot(**kwargs): |
Collaborator
There was a problem hiding this comment.
Can you please redirect this to post_train with a deprecation warning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #1109 to obtain models without training_args
SUMMARY:
oneshotto post_trainpost_trainhave its own pipeline, decoupled formmainpost_train's input arguments only dependent onModelArguments,DatasetArguments, andRecipeArguments. AnyTrainingArguments-related input arg will raise an error. Ex.overwrite_output_dir.oneshotusage in the function name (run_oneshot_and_finetune), Enum attributes (RecipeStages), variable name (oneshot_model) topost_train`."tests/llmcompressor/transformers/oneshot/oneshot_configs")TEST PLAN:
oneshotusinggrep.FOLLOWUPS:
SessionMixin.apply)