Skip to content

Make transformers-tests job conditional on files changed#1197

Merged
dsikka merged 3 commits intomainfrom
exclude-some-changes
Feb 26, 2025
Merged

Make transformers-tests job conditional on files changed#1197
dsikka merged 3 commits intomainfrom
exclude-some-changes

Conversation

@dbarbuzzi
Copy link
Copy Markdown
Collaborator

@dbarbuzzi dbarbuzzi commented Feb 26, 2025

SUMMARY:
Make transformers-tests job conditional on files changed by way of using the tj-actions/changed-files@v45 action to check which files changed (ignoring files/folders based on a separate trial: #1194).

TEST PLAN:
Verify this PR:

  1. Correctly results in skipping the transformers-tests job
  2. Allows merging with the skipped job

Signed-off-by: Domenic Barbuzzi <domenic@neuralmagic.com>
@dbarbuzzi dbarbuzzi added the ready When a PR is ready for review label Feb 26, 2025
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Signed-off-by: Domenic Barbuzzi <domenic@neuralmagic.com>
@dbarbuzzi
Copy link
Copy Markdown
Collaborator Author

@dsikka If this PR's current state works as expected, before merging, I want to make one change to how files are matched (change below). The change here is to include the test-check-transformers.yaml workflow file specifically, as any changes to this workflow should result in it being executed. As with other testing for this PR, I have tested the below changes in an external repo. It seems using the ! prefix does not work the same way with files_ignored which demands the switch to the files input approach instead.

         uses: tj-actions/changed-files@v45
         with:
-          files_ignore: |
-            examples/**
-            tests/e2e/**
-            tests/lmeval/**
-            tests/examples/**
-            **/*.md
-            .github/workflows/*
+          files: |
+            **
+            !examples/**
+            !tests/e2e/**
+            !tests/lmeval/**
+            !tests/examples/**
+            !**/*.md
+            !.github/**
+            .github/workflows/test-check-transformers.yaml

kylesayrs
kylesayrs previously approved these changes Feb 26, 2025
dsikka
dsikka previously approved these changes Feb 26, 2025
Signed-off-by: Domenic Barbuzzi <domenic@neuralmagic.com>
@dbarbuzzi dbarbuzzi dismissed stale reviews from dsikka and kylesayrs via bc2dd9f February 26, 2025 19:08
@dsikka dsikka enabled auto-merge (squash) February 26, 2025 19:10
@dsikka dsikka requested a review from kylesayrs February 26, 2025 19:12
@dsikka dsikka disabled auto-merge February 26, 2025 20:37
@dsikka dsikka merged commit 29ddedb into main Feb 26, 2025
8 checks passed
@dsikka dsikka deleted the exclude-some-changes branch February 26, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants