Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
added 2 commits
February 28, 2025 10:06
This was referenced Feb 28, 2025
added 3 commits
February 28, 2025 17:40
Signed-off-by: George Ohashi <george@neuralmagic.com>
brian-dellabetta
previously approved these changes
Mar 3, 2025
Collaborator
brian-dellabetta
left a comment
brian-dellabetta
left a comment
There was a problem hiding this comment.
should we do a linter check here or will the tests capture full coverage of the changes?
dsikka
reviewed
Mar 3, 2025
Collaborator
dsikka
left a comment
dsikka
left a comment
There was a problem hiding this comment.
This is just changing variable names, not the actual class name?
Author
|
Yes
|
Signed-off-by: George Ohashi <george@neuralmagic.com>
brian-dellabetta
requested changes
Mar 4, 2025
Collaborator
brian-dellabetta
left a comment
brian-dellabetta
left a comment
There was a problem hiding this comment.
looks like some things were changed in a find+replace that shouldn't have been
brian-dellabetta
approved these changes
Mar 5, 2025
dsikka
approved these changes
Mar 5, 2025
dsikka
pushed a commit
that referenced
this pull request
Mar 5, 2025
brian-dellabetta
pushed a commit
that referenced
this pull request
Mar 10, 2025
…ot (#1212) Order of reviews: #1206 #1207 #1209 #1212 <-- Here #1214 SUMMARY: * Move the preprocessing and postprocessing logic out of `src/llmcompressor/transformers/finetune/text_generation.py` and into `src/llmcompressor/entrypoints/utils.py` TEST PLAN: Pass tests Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
kylesayrs
pushed a commit
that referenced
this pull request
Mar 13, 2025
Order of reviews: #1206 #1207 #1209 #1212 #1214 <-- Here SUMMARY: * Refactor Training pipeline * Remove initialize, finalize from the session functions * Add training information on entrypoints/readme.md on the different types of training that can be carried out on llm-compressor * Decouple training from text_generation.py::main. The new logic loves in llmcompressor/entrypoints/train.py that takes the flow of pre-process, carry out training logic and then post-process * Delete outdated info on transformers/finetune/readme.md * Update session_mixin.py to use session().initialize or session().finalize. * Deprecate train.py in text_generation.py, raising deprecation message if used. * Update tests to use llmcompressor's train, not llmcompressor.transformers' train TEST PLAN: * Pass tests --------- Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order of reviews:
#1206 <-- Here
#1207
#1209
#1212
#1214
SUMMARY:
Rename data_args to dataset_args
TEST PLAN:
Pass tests
FInd
data_argsusinggrep