Skip to content

Remove MonkeyPatch for GPUs #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsikka merged 1 commit into from
Mar 5, 2025
Merged

Remove MonkeyPatch for GPUs #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tests/llmcompressor/transformers/finetune/test_finetune_no_recipe_custom_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def create_mock_file(self, extension, content, path, filename):

def tearDown(self):
shutil.rmtree(self.output)
self.monkeypatch.undo()


@pytest.mark.integration
Expand All @@ -121,11 +120,8 @@ class TestOneshotCustomDatasetSmall(TestFinetuneNoRecipeCustomDataset):
def setUp(self):
import torch

self.monkeypatch = pytest.MonkeyPatch()

if torch.cuda.is_available():
self.device = "cuda:0"
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")
else:
self.device = "cpu"

Expand All @@ -147,15 +143,12 @@ def setUp(self):
import torch
from transformers import AutoModelForCausalLM

self.monkeypatch = pytest.MonkeyPatch()
self.device = "cuda:0"
self.output = "./oneshot_output"
self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")

self.model = AutoModelForCausalLM.from_pretrained(
self.model, device_map=self.device, torch_dtype=torch.bfloat16
)
self.monkeypatch = pytest.MonkeyPatch()

def test_oneshot_then_finetune_gpu(self):
self._test_finetune_wout_recipe_custom_dataset()
4 changes: 0 additions & 4 deletions tests/llmcompressor/transformers/finetune/test_oneshot_and_finetune_with_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,13 @@ def setUp(self):
self.output = "./finetune_output"
# finetune workflows in general seem to have trouble with multi-gpus
# use just one atm
self.monkeypatch = pytest.MonkeyPatch()

def test_oneshot_and_finetune_with_tokenizer(self):
from datasets import load_dataset
from transformers import AutoModelForCausalLM, AutoTokenizer

from llmcompressor.transformers import compress

self.monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "0")

recipe_str = (
"tests/llmcompressor/transformers/finetune/test_alternate_recipe.yaml"
)
Expand Down Expand Up @@ -71,4 +68,3 @@ def test_oneshot_and_finetune_with_tokenizer(self):

def tearDown(self):
shutil.rmtree(self.output)
self.monkeypatch.undo()