Merged
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
kylesayrs
commented
Mar 10, 2025
kylesayrs
commented
Mar 10, 2025
horheynm
approved these changes
Mar 10, 2025
brian-dellabetta
approved these changes
Mar 10, 2025
dsikka
approved these changes
Mar 10, 2025
dsikka
reviewed
Mar 10, 2025
Collaborator
dsikka
left a comment
There was a problem hiding this comment.
Just so I understand, we're removing the functionality to track past stages? Which I think landed not too long ago
Collaborator
Author
|
@dsikka That functionality breaks only for this example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Background
appending. This caused sgpt to initialize twice and gptq to never initialize, leading to a sparsity-only quantization configsession.reset()in between stagesrecipe.yamlfiles which do not have the full recipe history. However, I believe this is acceptable for the time being, as the stage runner and this work flow will be removed in the next release.