Closed
Conversation
kylesayrs
approved these changes
Mar 13, 2025
Collaborator
kylesayrs
left a comment
kylesayrs
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
dsikka
requested changes
Mar 13, 2025
Collaborator
dsikka
left a comment
dsikka
left a comment
There was a problem hiding this comment.
I think we still want to support 3.9 for the time being. We should update the incorrect lines
Collaborator
|
Closing this out as @rahul-tuli is putting up the full fix in #1287. As @dsikka said, we have to support Python 3.9 until it is EOL in October and the code needs to be updated to be 3.9 friendly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1250
SUMMARY:
Chained context managers were introduced by python3.10
TEST PLAN:
N/A