[Tests] Use requires_gpu, fix missing gpu test skip, add explicit test for gpu from gha#1264
Merged
[Tests] Use requires_gpu, fix missing gpu test skip, add explicit test for gpu from gha#1264
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
dsikka
requested changes
Mar 18, 2025
Collaborator
There was a problem hiding this comment.
Why not update/use existing tools?
llm-compressor/tests/testing_utils.py
Line 40 in cf6a304
Collaborator
Author
dsikka
reviewed
Apr 30, 2025
Collaborator
dsikka
left a comment
dsikka
left a comment
There was a problem hiding this comment.
still not sure why we need this if these exist: tests/testing_utils.py
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Collaborator
Author
|
@dsikka All tests are now updated to use |
kylesayrs
changed the title
dsikka
approved these changes
Apr 30, 2025
brian-dellabetta
approved these changes
Apr 30, 2025
kylesayrs
added a commit
that referenced
this pull request
May 4, 2025
…t for gpu from gha (#1264) ## Purpose ## * Update all tests to use `requires_gpu` decorator * Add GPU mark skip for `test_compressor_stacking`, which requires a GPU * Add an explicit GPU test for GHA, so as to unambiguously catch situations where CUDA is not properly installed on a runner --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
requires_gpudecoratortest_compressor_stacking, which requires a GPU