Skip to content

[BugFix] TRL distillation bug fix#1278

Merged
dsikka merged 2 commits intomainfrom
bug-trl
Apr 1, 2025
Merged

[BugFix] TRL distillation bug fix#1278
dsikka merged 2 commits intomainfrom
bug-trl

Conversation

@horheynm
Copy link
Copy Markdown

@horheynm horheynm commented Mar 24, 2025

SUMMARY:
Bug fix for

0/test_example_scripts_ex_trl_co0/examples/trl_mixin/sft_trainer.py", line 15, in _init\n    super().init(*args, **kwargs)\nTypeError: SessionManagerMixIn.init_() missing 1 required positional argument: \'dataset_args\'\n').returncode

Solution is to revert the dataset args to optional back again

TEST PLAN:
Pass script run

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka added the ready When a PR is ready for review label Mar 26, 2025
@dsikka dsikka merged commit d2263cd into main Apr 1, 2025
8 checks passed
@dsikka dsikka deleted the bug-trl branch April 1, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants