Skip to content

[GPTQ] Add inversion fallback #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsikka merged 4 commits into from
Apr 1, 2025
Merged

[GPTQ] Add inversion fallback #1283

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
630f76c
add inversion fallback
kylesayrs Mar 25, 2025
56a5f14
more explicit about fallback
kylesayrs Apr 1, 2025
6d9aac7
Merge branch 'main' into kylesayrs/gptq-inversion-fallback
dsikka Apr 1, 2025
ef53b33
Merge branch 'main' into kylesayrs/gptq-inversion-fallback
dsikka Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/llmcompressor/modifiers/quantization/gptq/gptq_quantize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
QuantizationStrategy,
fake_quantize,
)
from loguru import logger

from llmcompressor.modifiers.utils import SPARSITY_THRESHOLD
from llmcompressor.observers.base import Observer
Expand Down Expand Up @@ -161,11 +162,13 @@ def quantize_weight(
H = torch.linalg.cholesky(H, upper=True)
Hinv = H
except torch._C._LinAlgError:
raise torch._C._LinAlgError(
logger.warning(
"Failed to invert hessian due to numerical instability. Consider "
"increasing GPTQModifier.dampening_frac, increasing the number "
"of calibration samples, or shuffling the calibration dataset"
"of calibration samples, or shuffling the calibration dataset. "
"Falling back to round-to-nearest for this module."
)
Hinv = H = torch.eye(num_columns, dtype=H.dtype, device=H.device)

# See section 3.4 of https://arxiv.org/abs/2203.07259
for i1 in range(0, num_columns, blocksize):
Expand Down