Skip to content

[Transformers] Support latest transformers#1352

Merged
dsikka merged 8 commits intomainfrom
update_transformers
Apr 21, 2025
Merged

[Transformers] Support latest transformers#1352
dsikka merged 8 commits intomainfrom
update_transformers

Conversation

@dsikka
Copy link
Copy Markdown
Collaborator

@dsikka dsikka commented Apr 15, 2025

SUMMARY:

  • Skip Int8 decompression tests (failing as of >4.49)
  • Bump to latest transformers
  • Clean-up recipes across test cases to make them make more sense
  • Update test cases to use model dtype and proper inputs for oneshot/train

Requires

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Copy Markdown
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes but we could revert most of these when transformers upstream is resolved?

@dsikka
Copy link
Copy Markdown
Collaborator Author

dsikka commented Apr 16, 2025

Lots of changes but we could revert most of these when transformers upstream is resolved?

We can revert the 3 skipped tests but otherwise, the updates to recipes/tests were all to improve on them/bring them up to speed with more logical cases

@dsikka dsikka marked this pull request as ready for review April 21, 2025 19:22
@dsikka dsikka added the ready When a PR is ready for review label Apr 21, 2025
@dsikka dsikka enabled auto-merge (squash) April 21, 2025 20:08
@dsikka dsikka requested a review from kylesayrs April 21, 2025 20:55
@dsikka dsikka merged commit 577c29f into main Apr 21, 2025
10 checks passed
@dsikka dsikka deleted the update_transformers branch April 21, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants