Move: recipe parsing test from e2e/ to main test suite#1360
Merged
rahul-tuli merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
… been moved to the main test suite to ensure it runs during CI. Changes: - Relocated the test to `tests/` since it doesn't require full end-to-end setup. - Refactored to use `tmp_path` for clean output handling. - Renamed test and fixtures for improved clarity and maintainability. - Added minimal output assertion to ensure oneshot execution is verifiable. - Removed the unused `e2e` version of the test. Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
rahul-tuli
requested review from
brian-dellabetta,
Copilot,
dsikka and
kylesayrs
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/llmcompressor/recipe/test_recipe_parsing.py:94
- [nitpick] Consider enhancing this assertion to specifically verify that the expected output artifacts are produced, rather than just checking for any file in the output directory.
assert output_path.exists() and any(output_path.iterdir()), f"No output artifacts found in: {output_path}"
markurtz
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relocates the
test_recipe_parsingtest from thetests/e2e/directory to the main test suite to ensure it is executed as part of the regular CI workflow.Rationale
e2e/, and is currently excluded from automated test runs.Changes
tests/e2e/and deleted the original.tmp_pathfor safe and isolated output handling.oneshot()pipeline.Coverage
The test validates that the
oneshot()function accepts: