Skip to content

[Testing] Reduce error verbosity of cleanup#1365

Merged
kylesayrs merged 2 commits intomainfrom
kylesayrs/clearer-errors
Apr 22, 2025
Merged

[Testing] Reduce error verbosity of cleanup#1365
kylesayrs merged 2 commits intomainfrom
kylesayrs/clearer-errors

Conversation

@kylesayrs
Copy link
Copy Markdown
Collaborator

@kylesayrs kylesayrs commented Apr 21, 2025

Purpose

  • When tests fail, they often show the error that occurs during cleanup, rather than the error that caused the tests to fail
ERROR tests/llmcompressor/transformers/obcq/test_consecutive_runs.py::TestConsecutiveRunsSmall_0_commit::test_consecutive_runs_small - FileNotFoundError: [Errno 2] No such file or directory: './oneshot_output'

Changes

  • Check if a directory exists before attempting to delete it during cleanup

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs marked this pull request as ready for review April 22, 2025 17:14
@kylesayrs kylesayrs added the ready When a PR is ready for review label Apr 22, 2025
Copy link
Copy Markdown
Collaborator

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on using pathlib for these changes?

@kylesayrs kylesayrs enabled auto-merge (squash) April 22, 2025 19:04
@kylesayrs kylesayrs merged commit 0422fc1 into main Apr 22, 2025
8 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/clearer-errors branch April 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants