-
Notifications
You must be signed in to change notification settings - Fork 207
[Transform] Spinquant with R1 and R2 #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 33 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
ba617db
wip
kylesayrs 2f5b1c8
use random-hadamard, add correctness tests
kylesayrs 3aa35e7
add correctness test, note that precision makes a large difference
kylesayrs b6c088e
add on lifecycle methods
brian-dellabetta d1eb2a1
Merge branch 'main' into kylesayrs/transform-modifier
brian-dellabetta 3207124
TransformModifier with SpinQuant R1&R2
brian-dellabetta a88ca3c
spinquant and quip_online, running but outputting gibberish
brian-dellabetta 5bd51df
updated example
brian-dellabetta 3c216dd
DummyModel script
brian-dellabetta bbcdc8c
implement fuse_norm_linears
kylesayrs bd7f4d5
Merge branch 'kylesayrs/fuse-helpers' into bdellabe/transform-modifier
kylesayrs f5c2150
R1 working
kylesayrs dc5c30c
add r2, increase precision
kylesayrs 7172c26
spinquant modifier
kylesayrs 9298e82
remove space
kylesayrs f77226d
use iterable
kylesayrs fdb64b5
add rotation validation
kylesayrs 5daa2d5
embedding fusion
kylesayrs 0e9af7b
add missing norm fusion
kylesayrs fce83be
use norm mappings
kylesayrs a979f8a
break into separate files
kylesayrs 4cab29e
small cleanup
kylesayrs f1cc987
cleanup
kylesayrs a7bb2e2
more cleanup
kylesayrs 0cf0188
make new weight on cpu
kylesayrs 53ea307
standardize, make modifier serializable
kylesayrs 4b4257f
add compress model script
kylesayrs dc7ac1a
use untie_word_embeddings
kylesayrs 8542f8d
style
kylesayrs b1e637e
better registery logic
kylesayrs b44ac81
remove dummy model test (add later)
kylesayrs 7a52b71
docstring
kylesayrs f4d7ec6
update docstring
kylesayrs f18d0e8
rename example file
kylesayrs cec2914
use match_modules_set
kylesayrs f6c797e
Merge branch 'main' into bdellabe/transform-modifier
brian-dellabetta 0c5c514
unit test fixes
brian-dellabetta f2ef7cf
style fixes
brian-dellabetta d0e5bc5
remove hardcoded pipeline logic
brian-dellabetta 31ac8e9
docstrings
brian-dellabetta a4abb3d
stylefixes
brian-dellabetta 63018c6
Merge branch 'main' into bdellabe/transform-modifier
brian-dellabetta 4dcaeaa
add precision, add tests
kylesayrs 88acb8d
remove print statement
kylesayrs 98da74e
reduce diff
kylesayrs 4705dbd
remove unused file
kylesayrs 79fb6a8
fix typo
kylesayrs d95b1cc
use datafree pipeline in example
kylesayrs 227f8e5
add messages to NotImplementedErrors
brian-dellabetta c32ca37
Merge branch 'main' into bdellabe/transform-modifier
brian-dellabetta b857da3
Merge branch 'main' into bdellabe/transform-modifier
brian-dellabetta d861bbb
minor touchups
brian-dellabetta 062d908
more touchups
brian-dellabetta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# python3 compress_model.py --model_id meta-llama/Llama-3.2-1B-Instruct --transform_type random-hadamard | ||
import argparse | ||
from transformers import AutoModelForCausalLM, AutoTokenizer | ||
|
||
from llmcompressor import oneshot | ||
from llmcompressor.modifiers.quantization import QuantizationModifier | ||
from llmcompressor.modifiers.transform import SpinQuantModifier | ||
from llmcompressor.utils import dispatch_for_generation | ||
|
||
def parse_args(): | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument("--model_id", type=str, help="Model stub to compress") | ||
parser.add_argument("--transform_type", type=str, default=None, help="Type of transform used in SpinQuantModifier") | ||
parser.add_argument("--scheme", type=str, default=None, help="Quantization scheme (e.g. W4A16)") | ||
return parser.parse_args() | ||
|
||
if __name__ == "__main__": | ||
args = parse_args() | ||
|
||
# Select model and load it. | ||
MODEL_ID = args.model_id | ||
model = AutoModelForCausalLM.from_pretrained(MODEL_ID, torch_dtype="auto") | ||
tokenizer = AutoTokenizer.from_pretrained(MODEL_ID) | ||
|
||
# Select number of samples. 512 samples is a good place to start. | ||
# Increasing the number of samples can improve accuracy. | ||
NUM_CALIBRATION_SAMPLES = 512 | ||
MAX_SEQUENCE_LENGTH = 2048 | ||
|
||
# Configure the quantization algorithm to run. | ||
recipe = [] | ||
if args.transform_type: | ||
recipe.append(SpinQuantModifier(rotations=["R1", "R2"], transform_type=args.transform_type)) | ||
|
||
if args.scheme: | ||
recipe.append(QuantizationModifier(targets="Linear", scheme=args.scheme, ignore=["lm_head"])) | ||
|
||
# Apply algorithms. | ||
oneshot( | ||
model=model, | ||
recipe=recipe, | ||
dataset="ultrachat_200k", | ||
splits={"calibration": f"train_sft[:{NUM_CALIBRATION_SAMPLES}]"}, | ||
max_seq_length=MAX_SEQUENCE_LENGTH, | ||
num_calibration_samples=NUM_CALIBRATION_SAMPLES, | ||
) | ||
|
||
# Confirm generations of the quantized model look sane. | ||
print("\n\n") | ||
print("========== SAMPLE GENERATION ==============") | ||
dispatch_for_generation(model) | ||
input_ids = tokenizer("Hello my name is", return_tensors="pt").input_ids.to("cuda") | ||
output = model.generate(input_ids, max_new_tokens=100) | ||
print(tokenizer.decode(output[0])) | ||
print("==========================================\n\n") | ||
|
||
# Save to disk compressed. | ||
SAVE_DIR = MODEL_ID.split("/")[1] + f"-{args.transform_type}-{args.scheme}" | ||
model.save_pretrained(SAVE_DIR, save_compressed=True) | ||
tokenizer.save_pretrained(SAVE_DIR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
from datasets import load_dataset | ||
from transformers import AutoModelForCausalLM, AutoTokenizer | ||
|
||
from llmcompressor import oneshot | ||
from llmcompressor.modifiers.quantization import QuantizationModifier | ||
from llmcompressor.modifiers.transform import SpinQuantModifier | ||
from llmcompressor.utils import dispatch_for_generation | ||
|
||
# Select model and load it. | ||
MODEL_ID = "meta-llama/Meta-Llama-3-8B-Instruct" | ||
|
||
model = AutoModelForCausalLM.from_pretrained( | ||
MODEL_ID, | ||
torch_dtype="auto", | ||
) | ||
tokenizer = AutoTokenizer.from_pretrained(MODEL_ID) | ||
|
||
# Select calibration dataset. | ||
DATASET_ID = "HuggingFaceH4/ultrachat_200k" | ||
DATASET_SPLIT = "train_sft" | ||
|
||
# Select number of samples. 512 samples is a good place to start. | ||
# Increasing the number of samples can improve accuracy. | ||
NUM_CALIBRATION_SAMPLES = 512 | ||
MAX_SEQUENCE_LENGTH = 2048 | ||
|
||
# Load dataset and preprocess. | ||
ds = load_dataset(DATASET_ID, split=f"{DATASET_SPLIT}[:{NUM_CALIBRATION_SAMPLES}]") | ||
ds = ds.shuffle(seed=42) | ||
|
||
|
||
def preprocess(example): | ||
return { | ||
"text": tokenizer.apply_chat_template( | ||
example["messages"], | ||
tokenize=False, | ||
) | ||
} | ||
|
||
|
||
ds = ds.map(preprocess) | ||
|
||
|
||
# Tokenize inputs. | ||
def tokenize(sample): | ||
return tokenizer( | ||
sample["text"], | ||
padding=False, | ||
max_length=MAX_SEQUENCE_LENGTH, | ||
truncation=True, | ||
add_special_tokens=False, | ||
) | ||
|
||
|
||
ds = ds.map(tokenize, remove_columns=ds.column_names) | ||
|
||
# Configure the quantization algorithm to run. | ||
# * apply spinquant transforms to model in order to make quantization easier | ||
# * quantize the weights to 4 bit with GPTQ with a group size 128 | ||
recipe = [ | ||
SpinQuantModifier(rotations=["R1", "R2"], transform_type="hadamard"), | ||
QuantizationModifier(targets="Linear", scheme="W4A16", ignore=["lm_head"]), | ||
] | ||
|
||
# Apply algorithms. | ||
oneshot( | ||
model=model, | ||
recipe=recipe, | ||
dataset=ds, | ||
max_seq_length=MAX_SEQUENCE_LENGTH, | ||
num_calibration_samples=NUM_CALIBRATION_SAMPLES, | ||
) | ||
|
||
# Confirm generations of the quantized model look sane. | ||
print("\n\n") | ||
print("========== SAMPLE GENERATION ==============") | ||
dispatch_for_generation(model) | ||
input_ids = tokenizer("Hello my name is", return_tensors="pt").input_ids.to("cuda") | ||
output = model.generate(input_ids, max_new_tokens=100) | ||
print(tokenizer.decode(output[0])) | ||
print("==========================================\n\n") | ||
|
||
# Save to disk compressed. | ||
SAVE_DIR = MODEL_ID.split("/")[1] + "-transformed-w4a16" | ||
model.save_pretrained(SAVE_DIR, save_compressed=True) | ||
tokenizer.save_pretrained(SAVE_DIR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# flake8: noqa | ||
|
||
from .fuse import * | ||
from .prepare import * |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
from typing import Iterable | ||
|
||
import torch | ||
from compressed_tensors import ( | ||
align_module_device, | ||
get_execution_device, | ||
update_offload_parameter, | ||
) | ||
from transformers.models.llama.modeling_llama import LlamaRMSNorm | ||
|
||
__all__ = ["normalize_embedding", "fuse_norm_linears"] | ||
|
||
|
||
PRECISION = torch.float64 | ||
|
||
|
||
def normalize_embedding(embedding: torch.nn.Module): | ||
if isinstance(embedding, (torch.nn.Embedding)): | ||
with align_module_device(embedding): | ||
weight_dtype = embedding.weight.dtype | ||
weight = embedding.weight.to(PRECISION) | ||
new_weight = weight - weight.mean(dim=-1, keepdim=True) | ||
new_weight = new_weight.to(weight_dtype) | ||
|
||
update_offload_parameter(embedding, "weight", new_weight) | ||
|
||
else: | ||
raise ValueError(f"Cannot normalize embedding of type {type(embedding)}") | ||
|
||
|
||
def fuse_norm_linears(norm: torch.nn.Module, linears: Iterable[torch.nn.Linear]): | ||
""" | ||
Fuse a norm layer into subsequent linear layers. This useful for ensuring transform | ||
invariance between norm and linear layers. | ||
|
||
Note that a model cannot be properly trained after its norms have been fused | ||
|
||
:param norm: norm layer whose weight will be fused into subsequent linears | ||
:param linears: linear layers which directly follow the norm layer | ||
""" | ||
if isinstance(norm, (torch.nn.RMSNorm, LlamaRMSNorm)): | ||
for linear in linears: | ||
# NOTE: spinquant does this op in float64 | ||
exec_device = get_execution_device(norm) | ||
with align_module_device(norm, exec_device), align_module_device( | ||
linear, exec_device | ||
): | ||
weight_dtype = linear.weight.dtype | ||
new_weight = linear.weight.to(PRECISION) * norm.weight.to(PRECISION) | ||
new_weight = new_weight.to(weight_dtype) | ||
|
||
update_offload_parameter(linear, "weight", new_weight) | ||
|
||
new_norm_weight = torch.ones_like(norm.weight, device="cpu") | ||
update_offload_parameter(norm, "weight", new_norm_weight) | ||
|
||
else: | ||
raise ValueError(f"Cannot fuse norm of type {type(norm)}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# flake8: noqa | ||
|
||
from .spinquant import SpinQuantModifier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# flake8: noqa | ||
|
||
from .base import * |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.