Skip to content

fix pydantic validation errors #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025
Merged

Conversation

brian-dellabetta
Copy link
Collaborator

@brian-dellabetta brian-dellabetta commented Aug 11, 2025

SUMMARY:
Recent changes to compressed-tensors are causing some llm-compressor unit tests to fail. Fixing them on this branch

TEST PLAN:
tests pass

@brian-dellabetta brian-dellabetta added the ready When a PR is ready for review label Aug 11, 2025
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @brian-dellabetta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses failing unit tests by updating the quantization scheme configuration in test_sparse.py. The failures were introduced by a recent change in the compressed-tensors library, necessitating an update to how quantization arguments are defined and applied.

Highlights

  • Update Quantization Imports: Added QuantizationStrategy and QuantizationType imports to align with the updated compressed-tensors API.
  • Refactor Quantization Scheme: Modified the QuantizationScheme for the fc1 layer, changing the target from a specific module name ("model.fc1") to a module type ("Linear").
  • Adjust Quantization Arguments: Updated the QuantizationArgs for weights to use the new parameters (num_bits, type, group_size, strategy, symmetric, dynamic) instead of the deprecated ones (precision, granularity, algorithm, blocksize).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a unit test to align with recent API changes in the compressed-tensors library. The modifications to QuantizationScheme correctly reflect the new API. I've identified a minor inconsistency in the test data where the configured quantization bit-width doesn't match the mocked data type. My suggestion aims to align these to improve the test's clarity and correctness.

kylesayrs
kylesayrs previously approved these changes Aug 11, 2025
@brian-dellabetta brian-dellabetta changed the title fix quant scheme errors fix pydantic validation errors Aug 11, 2025
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
@brian-dellabetta brian-dellabetta force-pushed the bdellabe/fix-quant-scheme-errors branch from ed772cb to c842655 Compare August 12, 2025 14:30
@brian-dellabetta brian-dellabetta merged commit d5a6a4b into main Aug 12, 2025
15 of 17 checks passed
@brian-dellabetta brian-dellabetta deleted the bdellabe/fix-quant-scheme-errors branch August 12, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants