[NVFp4][MoE Calibration] Fix MoE Calibration Context#1864
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Mixture of Experts (MoE) calibration context, ensuring that all experts are properly calibrated by default. This change enhances the reliability of MoE model quantization. Additionally, it optimizes the Qwen3 MoE NVFP4 example by significantly reducing the number of calibration samples, leading to faster execution of the example. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in Mixture-of-Experts (MoE) calibration, ensuring all experts are correctly calibrated by default. The core change adjusts the calibrate_all_experts parameter's default value to True within the moe_calibration_context, which is a sensible and correct fix. The accompanying reduction in calibration samples for the Qwen3 example is a practical adjustment to maintain example performance. My review includes suggestions to add a docstring for the modified function and to clarify the purpose of the low number of calibration samples in the example, both aimed at improving code clarity and maintainability.
SUMMARY: