Add E2E test config for AWQ symmetric quantization#1877
Add E2E test config for AWQ symmetric quantization#1877fynnsu merged 3 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @WenheLI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new end-to-end test configuration designed to validate the implementation of AWQ symmetric quantization. By adding a dedicated YAML file, it sets up a regression test for the TinyLlama model using a specific W4A16 quantization scheme and a defined dataset for calibration, directly contributing to the resolution of a reported issue. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new end-to-end test configuration for AWQ symmetric quantization, which is a valuable addition for regression testing. The configuration is mostly well-defined. My review includes a couple of suggestions to improve the test's performance within the CI environment and enhance the configuration's maintainability by leveraging automatic value generation from the test framework.
fynnsu
left a comment
There was a problem hiding this comment.
Hi @WenheLI, this looks great, thank you for submitting! I left a couple comments below for things to fix before we merge this.
Also it looks like the DCO check if failing currently. We require contributors to sign their commits. There's more info on the failing check for how to fix this.
Once those changes are in, I will approve the pr.
Signed-off-by: WenheLI <wl1508@nyu.edu>
Signed-off-by: WenheLI <wl1508@nyu.edu>
Signed-off-by: WenheLI <wl1508@nyu.edu>
e911ce4 to
4932699
Compare
brian-dellabetta
left a comment
There was a problem hiding this comment.
Thanks for the contribution! the default num_calibration_samples=256 should be fine
Adding a PR to try to add e2e test for resolving this ticket:
#1852
Still new to this codebase, so not sure if this aligns with what we want to do.
Let me know if I miss anything