[tests] remove pile-val-backup dataset from tests#1879
Merged
brian-dellabetta merged 3 commits intomainfrom Sep 30, 2025
Merged
[tests] remove pile-val-backup dataset from tests#1879brian-dellabetta merged 3 commits intomainfrom
brian-dellabetta merged 3 commits intomainfrom
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
fynnsu
previously approved these changes
Sep 29, 2025
Collaborator
fynnsu
left a comment
There was a problem hiding this comment.
Looks good!
My only comment is maybe we should change the name of
tests/e2e/vLLM/recipes/WNA16/recipe_w4a16_group_quant_asym_awq.yaml
to match
tests/e2e/vLLM/recipes/WNA16/recipe_w4a16_awq_sym.yaml if we're just directly using the W4A16_ASYM scheme. But also fine as is.
shanjiaz
previously approved these changes
Sep 29, 2025
Collaborator
shanjiaz
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for fixing!
2dffddd
64a8ea9 to
2dffddd
Compare
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
fynnsu
approved these changes
Sep 29, 2025
shanjiaz
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR
pile-val-datasetfrom e2e tests, as it is no longer used in examples and the processing logic was flawedAWQModifier.validate_model_afterwas preventingQuantizationMixin.validate_model_afterfrom running). With these changes, tests pass and the compressed model generates meaningful responses. It was previously generating all 0sTEST PLAN:
CADENCE=nightly TEST_DATA_FILE=tests/e2e/vLLM/configs/w4a16_grouped_quant_sym_awq.yaml pytest -s tests/e2e/vLLM/test_vllm.pyandCADENCE=nightly TEST_DATA_FILE=tests/e2e/vLLM/configs/w4a16_grouped_quant_asym_awq.yaml pytest -s tests/e2e/vLLM/test_vllm.pyboth pass with output like