Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on refining configuration settings across various model evaluation and vLLM test configurations. It includes a fix for an incorrect Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several e2e test configuration files. The main change corrects a save_dir path to align with its corresponding quantization scheme. Additionally, gpu_memory_utilization settings are introduced in some configurations, and recovery thresholds are adjusted. The changes appear to be routine updates and fixes. I've provided a few suggestions to add a final newline to some of the modified YAML files to align with best practices and improve consistency.
I am having trouble creating individual review comments. Click here to see my feedback.
tests/e2e/vLLM/configs/qwen3_fp8_dynamic_per_token.yaml (5)
It's a good practice to end files with a newline character. Some tools and standards (like POSIX) expect it, and it improves consistency across the codebase.
gpu_memory_utilization: 0.55
tests/e2e/vLLM/configs/w4a16_actorder_none.yaml (9)
Please add a newline at the end of the file. It's a common convention that helps prevent issues with file processing tools and git.
save_dir: TinyLlama-1.1B-Chat-v1.0-actorder-none
tests/e2e/vLLM/configs/w4a16_grouped_quant_asym_awq.yaml (9)
This file is missing a final newline. Adding one is a standard practice that ensures file integrity and compatibility with various development tools.
gpu_memory_utilization: 0.85
|
I believe this should be fixed by #2375 |
SUMMARY:
cc @kylesayrs