Update tests for CompressedLinear removal#2325
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @colldata79, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the test suite to remove all dependencies and references to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively removes test code and comments related to CompressedLinear, aligning the test suite with its removal from the compressed-tensors library. The changes are clean, necessary, and correctly implemented. The removal of the unused import and the obsolete test class Test_Compressed_CompressedLinear_Decompressed_Linear improves code maintainability. The updates to comments in other test files ensure documentation is accurate. Overall, this is a good cleanup PR.
- Remove CompressedLinear import from test_run_compressed.py - Delete Test_Compressed_CompressedLinear_Decompressed_Linear class - Update comments in test files to remove CompressedLinear references This change aligns tests with the removal of CompressedLinear from compressed-tensors library. Related: vllm-project#2279 Signed-off-by: colldata79 <colltrix@colltrix.com>
ccc7a3d to
662d145
Compare
- Remove CompressedLinear import from test_run_compressed.py - Delete Test_Compressed_CompressedLinear_Decompressed_Linear class - Update comments in test files to remove CompressedLinear references This change aligns tests with the removal of CompressedLinear from compressed-tensors library. Related: vllm-project#2279 depends on vllm-project/compressed-tensors#564 Signed-off-by: colldata79 <colltrix@colltrix.com> Co-authored-by: HDCharles <39544797+HDCharles@users.noreply.github.com> Co-authored-by: Kyle Sayers <kylesayrs@gmail.com>
This change aligns tests with the removal of CompressedLinear from compressed-tensors library.
Related: #2279
depends on vllm-project/compressed-tensors#564