Skip to content

Bdellabe/shared tensor caching #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brian-dellabetta merged 2 commits into from
Feb 14, 2026
Merged

Bdellabe/shared tensor caching #2367

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b7cbe
using torch hash_tensor and weakref
brian-dellabetta Feb 14, 2026
ee91ec9
Merge branch 'kylesayrs/shared_tensor_caching' into bdellabe/shared_t…
brian-dellabetta Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/llmcompressor/pipelines/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any, Generator

#from .helpers import TensorKeyWeakValueDictionary
from weakref import WeakKeyDictionary
from weakref import WeakKeyDictionary, ReferenceType, ref

import torch
from tqdm import tqdm
Expand Down Expand Up @@ -48,7 +48,7 @@ class IntermediatesCache:
# onload value -> offload value
# used to avoid excess memory usage when shared tensors are offloaded
#offload_values: WeakKeyDictionary[torch.Tensor, torch.Tensor] = WeakKeyDictionary()
offload_values: dict[int, torch.Tensor] = dict()
offload_values: dict[int, ReferenceType[torch.Tensor]] = dict()

def __init__(
self,
Expand Down Expand Up @@ -254,12 +254,13 @@ def _offload_value(
# Note: due to a (bug) in WeakKeyDictionary, we must check tensors using
# id. this is UNSAFE, since once the onloaded tensor is deleted, other
# python objects can reuse that id, leading to collisions.
if id(value) in cls.offload_values:
offloaded = cls.offload_values[id(value)]
value_hash = torch.hash_tensor(torch.view_as_real(value) if value.is_complex() else value)
if value_hash in cls.offload_values:
offloaded = cls.offload_values[value_hash]()
else:
# move to offload if no hit
offloaded = value.to(device=offload_device)
cls.offload_values[id(value)] = offloaded
cls.offload_values[value_hash] = ref(offloaded)

return IntermediateValue(
value=offloaded,
Expand Down
Loading