Refactor logging, CompressionLogger, support distributed#2408
Refactor logging, CompressionLogger, support distributed#2408
CompressionLogger, support distributed#2408Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the CompressionLogger by removing hardware-specific GPU monitoring code in favor of the torch.cuda interface and adds support for distributed environments. These changes are a good step towards simplification and better maintainability. However, I've identified a critical issue in the new memory usage logging logic which causes incorrect metrics to be reported and can lead to a ZeroDivisionError. I've provided a detailed comment with a suggested fix.
CompressionLogger, support distributedCompressionLogger, support distributed
brian-dellabetta
left a comment
There was a problem hiding this comment.
So much cleaner! Didn't know you could do this all through torch.cuda API
HDCharles
left a comment
There was a problem hiding this comment.
see comment, otherwise looks good
|
Tried running GPTQ on this branch, on amd device. output looks good |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
04ca9bc to
0bcef4f
Compare
Purpose
Changes
CompressionLoggerconfigure_loggercan now be called multiple timesconfigure_loggeris called again with the rank setTesting
Single-thread
Distributed