Conversation
Signed-off-by: phaelon74 <kahlid74@hotmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the model compression capabilities by integrating full support for Qwen3.5 MoE models. It introduces specialized calibration logic to accurately quantize these complex architectures, ensuring that all experts are properly accounted for during the compression process. The changes also include necessary structural adaptations for efficient deployment, alongside practical examples and validation tests. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds modeling support for the Qwen3.5 MoE family of models, including a calibration module, a usage example, and unit tests. The implementation is well-structured and follows existing patterns in the codebase. The new calibration module correctly handles expert decomposition and routing for calibration. The example and tests are comprehensive. I have one suggestion to improve code maintainability by removing a redundant method override. Overall, this is a great addition.
| def restore(self, original: torch.nn.Module) -> torch.nn.Module: | ||
| return original |
There was a problem hiding this comment.
The restore method is redundant and can be removed. The base class MoECalibrationModule already provides a correct implementation for permanent modules (where is_permanent=True). Since this module is permanent, its restore method is never called, making this override dead code. Removing it will improve maintainability by relying on the base class implementation and reducing code duplication.
|
Hi @phaelon74 - this is already being worked on #2383 |
Very cool, I was not aware of that. I shall close this down and add comments to that one. Thanks @dsikka |
SUMMARY:
Adding a modeling file for Qwen3.5 MoE family of models, similar to the GLM4_MOE Modeling file I added.
TEST PLAN:
Calib Test file added and example quanting file added. Quanting on both my RTX6000 and RTX 3090 rigs.