Skip to content

[Agents] Add claude skills for style and test#2445

Merged
dsikka merged 4 commits intomainfrom
kylesayrs/claude-rules
Mar 9, 2026
Merged

[Agents] Add claude skills for style and test#2445
dsikka merged 4 commits intomainfrom
kylesayrs/claude-rules

Conversation

@kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Mar 4, 2026

Purpose

  • Ensure that commits created by agents follow proper style guides
  • Ensure that tests run by agents use proper cuda safeguards

Changes

  • Added style.md and test.md skills under .claude folder

Related PRs

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the capabilities of the Claude AI agent by providing it with explicit instructions on how to handle code styling and testing within the project. These new "skills" will enable the agent to better understand and assist with development workflows related to code quality and test execution, particularly for GPU-dependent tests.

Highlights

  • New Claude Skills for Code Styling: Introduced a new skill file (.claude/skills/style.md) that provides instructions for maintaining code quality, including running 'make style' for auto-formatting and 'make quality' for validation, along with guidelines for line length and indentation.
  • New Claude Skills for Testing Procedures: Added a new skill file (.claude/skills/test.md) detailing how to run tests, specifically highlighting the requirement for a GPU and the use of 'canhazgpu' for proper GPU allocation during test execution.
  • Git Ignore Configuration Update: Modified the .gitignore file to remove the .claude/ directory from the list of ignored paths, ensuring that the new Claude skill files are tracked by version control.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .claude/skills/style.md
    • Added a new file containing instructions for code quality checks.
    • Included steps for running 'make style' and 'make quality'.
    • Provided guidelines for code formatting, such as line length.
  • .claude/skills/test.md
    • Added a new file outlining the process for running tests.
    • Emphasized the GPU requirement for all tests.
    • Detailed the usage of 'canhazgpu' for GPU allocation during testing.
  • .gitignore
    • Removed the '.claude/' entry from the ignore list.
Activity
  • The pull request description's summary section has not yet been filled out by the author.
  • The pull request description's test plan section has not yet been filled out by the author.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Claude skills for styling and testing code, and updates the .gitignore to include these new skill files in the repository. The new style.md skill provides correct instructions for code formatting and quality checks. The test.md skill provides instructions for running tests, but it could be improved for accuracy regarding GPU requirements and for consistency with the project's Makefile test configuration. I've provided a suggestion to update the testing instructions to be more precise and robust.

Note: Security Review has been skipped due to the limited scope of the PR.

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@dsikka dsikka enabled auto-merge (squash) March 7, 2026 15:42
@dsikka dsikka merged commit 58dc77e into main Mar 9, 2026
13 checks passed
@dsikka dsikka deleted the kylesayrs/claude-rules branch March 9, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants