Skip to content

[do not merge] test failing ci/cd#2459

Closed
brian-dellabetta wants to merge 1 commit intomainfrom
bdellabe/failing-deepseek-test
Closed

[do not merge] test failing ci/cd#2459
brian-dellabetta wants to merge 1 commit intomainfrom
bdellabe/failing-deepseek-test

Conversation

@brian-dellabetta
Copy link
Copy Markdown
Collaborator

SUMMARY:
"please provide a brief summary"

TEST PLAN:
"please outline how the changes were tested"

Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves as a dedicated test for the continuous integration and continuous deployment (CI/CD) pipeline. The code modifications are minimal and appear to be a vehicle to trigger and evaluate the pipeline's behavior, rather than introducing functional changes to the codebase.

Highlights

  • CI/CD Testing: This pull request is explicitly marked as a test for the CI/CD pipeline, indicated by the "[do not merge]" prefix in the title.
  • Test File Modification: A minor change was made to test_calib_deepseek_v3.py, involving the relocation of a commented-out line and the addition of an assertion message.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/llmcompressor/modeling/test_calib_deepseek_v3.py
    • Moved a commented-out torch.manual_seed line within the test_calib_deepseekv3_module function.
    • Added a descriptive string "Samples not close" to an assert torch.allclose statement.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be a test for CI/CD. The changes include a minor formatting adjustment and the addition of an assertion message to a torch.allclose call in a test. The assertion message is a good practice for improving test debuggability.

module = CalibrationDeepseekV3MoE(original, config, calibrate_all_experts=True)
with calibration_forward_context(module):
output = module(sample)
assert torch.allclose(true_output, output, atol=1e-6)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding an assertion message to torch.allclose calls improves test debuggability by providing context when an assertion fails. This helps in quickly understanding the cause of a test failure.

assert torch.allclose(true_output, output, atol=1e-6), "Samples not close"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant