fix transformers v5 & ministral compatibility#2470
fix transformers v5 & ministral compatibility#2470leo-bujdei-leonte wants to merge 1 commit intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's compatibility with the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates dependencies and code to be compatible with transformers v5. The changes look good, but I've found a potential typo in a dependency version in setup.py which could break package installation. Please take a look.
| "compressed-tensors==0.13.0" | ||
| if BUILD_TYPE == "release" | ||
| else "compressed-tensors>=0.13.1a2" | ||
| else "compressed-tensors==0.14.1a20260225" |
There was a problem hiding this comment.
The version for compressed-tensors appears to have a typo in the year. 2026 is in the future, which will likely cause package installation to fail as this version probably doesn't exist. Did you mean to use 2024?
| else "compressed-tensors==0.14.1a20260225" | |
| else "compressed-tensors==0.14.1a20240225" |
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
No description provided.